Merged
Conversation
cwsmith
approved these changes
Apr 30, 2025
Contributor
cwsmith
left a comment
cwsmith
left a comment
There was a problem hiding this comment.
Looks good. Thank you.
This replaces the build/test that doesn't use C++20?
Should we make C++20 the required default in the CMakeLists.txt?
Contributor
Author
|
If we start using any C++20 features then we should update the minimum, but we aren't using any right now so I don't see the need to |
Contributor
Author
|
And yes this replaces the build that uses earlier version of c++. |
Contributor
|
Sounds good. Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added test for c++20 on perlmutter