Merged
Conversation
jacobmerson
reviewed
Mar 31, 2025
Collaborator
jacobmerson
left a comment
jacobmerson
left a comment
There was a problem hiding this comment.
These changes are just to shift the Client and server interface to match?
Contributor
Author
|
This is still a work in progress, I changed it to a draft pull request. |
Collaborator
|
Alright, thanks. I wasn't sure if you wanted to take it in steps and wanted me to review at this stage. |
Contributor
Author
|
@jacobmerson This is ready now. Feel free to take a look. |
Collaborator
|
/runtests |
Collaborator
|
@Angelyr is the gpu test runner set up on this repo? |
Contributor
Author
|
@jacobmerson I am not sure, @cwsmith have you set up the gpu runner here? |
Contributor
|
I haven't. |
jacobmerson
approved these changes
Apr 7, 2025
Collaborator
|
I'm going to go ahead and merge it. We should get the GPU runner set up for PCMS and I'll open an issue for that. There were some other issues that crept in due to things being broken on GPU. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added coupler class