Removed inappropriate repository dependencies #159
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An "obj" package is designed to make ROOT understand LArSoft data objects, and it needs the minimum possible dependencies. In particular, is expected to depend only on other "obj" packages, no "alg" or art-dependent packages.
sbnobjdid not fulfil that requirement; one side effect is that attempting to loadsbn::crt::CRTHitor other objects fromsbnobj/Common/CRTfails:The reason is ROOT Cling interpreter trying to load algorithm code, which pulls
ranve-v3library in, and Cling can't parse it (yet — maybe enabling C++20 it could).The changes in this commit conform
sbnobjto that requirement.This PR requires
lardataobjv10_04_00, first merged in LArSoftv10_15_00(because of LArSoft issue #30090).Reviewers: the changes are of technical nature, no actual change is expected.
However, dependencies unnecessary to
sbnobjhave been removed, and it is possible that some packages that were (incorrectly) not declaring those dependencies will now fail to compile. In that case, those packages need to be fixed as well.So, asking a review from somebody with fingers into the build.