-
Notifications
You must be signed in to change notification settings - Fork 54
Light Calorimetry #878
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
lynnt20
wants to merge
60
commits into
develop
Choose a base branch
from
feature/lynnt_lightcalorimetry
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Light Calorimetry #878
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Version v09_67_00
- cleaned (but need to clean more) skipping products that aren't used (xarapuca flashes + truth products) for example to avoid nullptr
- cleaned (but need to clean more) skipping products that aren't used (xarapuca flashes + truth products) for example to avoid nullptr
- moved truth validation to a separate function - added lower/upper threshold for PE per channel - added fcl param to turn on/off evaluating all planes - option to add dir/refl efficiencies; NOTE: not really accounted for in the code yet
- merge the two previous trees into one - match-type can now differentiate between event/slice level easily
Version v09_89_01, patch release for SBN2024A
Version v09_93_01_02p02
Version v10_04_07
Version v10_06_02
- store simphotons at each opdet - calculate true light/charge based spatial-correction maps - calculate various versions of L1 reco
- update drift time correction with call to clocks - split by shower/track - add more tree branches
Version v10_11_01_01
…ing matches, add weighted avg - update median calculation to use `nth_element` - compiles but have not yet tested output
…ly produce data products - also specify pd types explicitly, default is coated pmts only
…, generic clean up
This was referenced Dec 10, 2025
Light Calorimetry: add sim energy deposit info and light calo info into cafs
SBNSoftware/sbncode#619
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add producer module to create light calorimetry data products. Creates new subdirectory
Calorimetryto store the module and fcls. Almost 3 years since the first commit! Reco2/caf level changes only.Checklist
Reviewers,AssigneesDevelopementRelevant PR links
Accompanying PRs: SBNSoftware/sbncode#619, SBNSoftware/sbnanaobj#181, SBNSoftware/sbnobj#158
Link(s) to docdb describing changes (optional)
Is there a docdb describing the issue this solves or the feature added?