adding TrackLikePidLabel: to cafmakerjob fcl files #853

sungbinoh · 2025-10-20T17:22:01Z

Description

This PR adds physics.producers.cafmaker.TrackLikePidLabel into cafmakerjob fcl files.
This is required to save the likelihood PID products created in reco2 stages into CAF.

For more information about the PID variables, please check SBN-doc-42330.

A relevant PR in larana that adds new PID class LikelihoodPIDAlg: PR41
A relevant PR in sbndcode to add LikelihoodPIDAlg product in reco2 stage PR849.
Relevant PRs in sbnanaobj and sbncode: sbnanaobj PR168 and sbncode PR593 .

$${\color{red}!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!}$$

$${\color{red}\bf{\textrm{IMPORTANT UPDATE June 22nd 2025:}}}$$ If you are making a PR which is intended as a patch for the CURRENT production (which started in Spring 2025), you must make two PRs: one for develop and one for the production/v10_06_00 branch.

$${\color{red}!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!}$$

Checklist

Added at least 1 label from available labels.
Assigned at least 1 reviewer under Reviewers,
Assigned all contributers including yourself under Assignees
Linked any relevant issues under Developement
Does this PR affect CAF data format? If so, please assign a CAF maintainer (PetrilloAtWork or JosiePaton) as additional reviewer.
Does this affect the standard workflow?
Is this PR a patch for the ongoing production? If so, separate PR must also be made for production/v10_06_00 branch!

Relevant PR links (optional)

Does this PR require merging another PR in a different repository (such as sbnanobj/sbnobj etc.)?

Yes. This PR requires multiple PRs bellow to be merged first.

Adding likelihood PID objects in reco2 stage: sbndcode PR849
Adding StandardRecord for likelihood based PID SRTrkLikePID: sbnanaobj PR168
Updating sbncode to add likelihood PID into CAF: sbncode PR593

Link(s) to docdb describing changes (optional)

Is there a docdb describing the issue this solves or the feature added?

This likelihood PID variable is based on a study performed by Sophia Vanderwaal in Summer 2025 SBN-doc-42330.

justinjmueller · 2025-10-20T17:25:14Z

This looks fine to me, but I will hold off on approving until we hear from others.

nathanielerowe · 2025-10-29T04:00:48Z

trigger build LArSoft/lar*@LARSOFT_SUITE_v10_11_01

FNALbuild · 2025-10-29T04:20:53Z

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

FNALbuild · 2025-10-29T04:21:48Z

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

FNALbuild · 2025-10-29T04:35:24Z

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

FNALbuild · 2025-10-29T04:56:53Z

❌ CI build for SBND Failed at phase ci_tests SBND on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the failed phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

nathanielerowe · 2025-10-29T17:08:44Z

@sungbinoh it looks like there is a cafmaker issue. Can you take a look?

70:   ====================================================================================================
71:   
72:   !! The following modules have been misconfigured: !!
73:   
74:   ----------------------------------------------------------------------------------------------------
75:   
76:   
77:   Module label: �[1mcafmaker�[0m
78:   module_type : �[1mCAFMaker�[0m
79:   
80:   Any parameters prefaced with '#' are optional.
81:   Unsupported parameters:
82:   
83:    + TrackLikePidLabel              [ /scratch/workspace/sbnd_ci/label_exp/swarm/label_exp2/swarm/SBND/localProducts_SBND_SBND_lar_ci_e26_prof/sbndcode/v10_11_01_01/fcl/cafmakerjob_sbnd_data_base.fcl:165 ]
84:   
85:   
86:   ====================================================================================================
87: ---- Configuration END
88: %MSG
89: Art has completed and will exit with status 9.

sungbinoh · 2025-10-29T18:42:58Z

@sungbinoh it looks like there is a cafmaker issue. Can you take a look?

70:   ====================================================================================================
71:   
72:   !! The following modules have been misconfigured: !!
73:   
74:   ----------------------------------------------------------------------------------------------------
75:   
76:   
77:   Module label: �[1mcafmaker�[0m
78:   module_type : �[1mCAFMaker�[0m
79:   
80:   Any parameters prefaced with '#' are optional.
81:   Unsupported parameters:
82:   
83:    + TrackLikePidLabel              [ /scratch/workspace/sbnd_ci/label_exp/swarm/label_exp2/swarm/SBND/localProducts_SBND_SBND_lar_ci_e26_prof/sbndcode/v10_11_01_01/fcl/cafmakerjob_sbnd_data_base.fcl:165 ]
84:   
85:   
86:   ====================================================================================================
87: ---- Configuration END
88: %MSG
89: Art has completed and will exit with status 9.

Hi @nathanielerowe , I think that it is because the PRs in sbncode and sbnanaobj are not merged yet.
As written in the description, there are PRs should be merged first.

FYI:

Yes. This PR requires multiple PRs bellow to be merged first.

Adding likelihood PID objects in reco2 stage: sbndcode #849
Adding StandardRecord for likelihood based PID SRTrkLikePID: sbnanaobj SBNSoftware/sbnanaobj#168
Updating sbncode to add likelihood PID into CAF: sbncode SBNSoftware/sbncode#593

nathanielerowe · 2025-10-29T18:56:43Z

Ah missed that, too many PR tabs open. Thanks!

nathanielerowe · 2025-11-18T01:57:14Z

trigger build SBNSoftware/sbnanaobj#593 SBNSoftware/sbnanaobj#168 LArSoft/lar*@LARSOFT_SUITE_v10_12_02 SBNSoftware/sbndaq-artdaq-core@v1_10_06 SBNSoftware/sbn*@SBN_SUITE_v10_12_02

FNALbuild · 2025-11-18T02:14:25Z

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

FNALbuild · 2025-11-18T02:16:31Z

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

FNALbuild · 2025-11-18T02:24:32Z

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

FNALbuild · 2025-11-18T02:44:09Z

❌ CI build for SBND Failed at phase ci_tests SBND on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

nathanielerowe · 2025-11-18T03:18:10Z

trigger build SBNSoftware/sbncode#593 SBNSoftware/sbnanaobj#168 LArSoft/lar*@LARSOFT_SUITE_v10_12_02 SBNSoftware/sbndaq-artdaq-core@v1_10_06 SBNSoftware/sbn*@SBN_SUITE_v10_12_02

FNALbuild · 2025-11-18T03:52:11Z

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

FNALbuild · 2025-11-18T03:52:35Z

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

FNALbuild · 2025-11-18T03:59:49Z

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

FNALbuild · 2025-11-18T04:18:24Z

❌ CI build for SBND Failed at phase build SBND on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

nathanielerowe · 2025-11-18T04:30:15Z

Looks like a quick fix somewhere for this build error. Maybe a header file missing in the sbncode PR?

4672: /scratch/workspace/sbnd_ci/label_exp/swarm/label_exp2/swarm/SBND/srcs/sbncode/sbncode/CAFMaker/FillReco.h:230:62: error: 'caf::SRTrkLikelihoodPID' has not been declared
4673:   230 |   void FillPlaneLikePID(const anab::ParticleID &particle_id, caf::SRTrkLikelihoodPID &srlikepid);
4674:       |                                                              ^~~
4675: /scratch/workspace/sbnd_ci/label_exp/swarm/label_exp2/swarm/SBND/srcs/sbncode/sbncode/CAFMaker/FillReco.cxx:911:62: error: 'caf::SRTrkLikelihoodPID' has not been declared
4676:   911 |   void FillPlaneLikePID(const anab::ParticleID &particle_id, caf::SRTrkLikelihoodPID &srlikepid) {
4677:       |                                                              ^~~
4678: /scratch/workspace/sbnd_ci/label_exp/swarm/label_exp2/swarm/SBND/srcs/sbncode/sbncode/CAFMaker/FillReco.cxx: In function 'void caf::FillPlaneLikePID(const anab::ParticleID&, int&)':
4679: /scratch/workspace/sbnd_ci/label_exp/swarm/label_exp2/swarm/SBND/srcs/sbncode/sbncode/CAFMaker/FillReco.cxx:915:15: error: request for member 'setDefault' in 'srlikepid', which is of non-class type 'int'
4680:   915 |     srlikepid.setDefault();
4681:       |               ^~~~~~~~~~
4682: /scratch/workspace/sbnd_ci/label_exp/swarm/label_exp2/swarm/SBND/srcs/sbncode/sbncode/CAFMaker/FillReco.cxx:922:23: error: request for member 'lambda_muon' in 'srlikepid', which is of non-class type 'int'
4683:   922 |             srlikepid.lambda_muon = AlgScore.fValue;
4684:       |                       ^~~~~~~~~~~
4685: /scratch/workspace/sbnd_ci/label_exp/swarm/label_exp2/swarm/SBND/srcs/sbncode/sbncode/CAFMaker/FillReco.cxx:923:23: error: request for member 'pid_ndof' in 'srlikepid', which is of non-class type 'int'
4686:   923 |             srlikepid.pid_ndof = AlgScore.fNdf;
4687:       |                       ^~~~~~~~
4688: /scratch/workspace/sbnd_ci/label_exp/swarm/label_exp2/swarm/SBND/srcs/sbncode/sbncode/CAFMaker/FillReco.cxx:926:23: error: request for member 'lambda_pion' in 'srlikepid', which is of non-class type 'int'
4689:   926 |             srlikepid.lambda_pion = AlgScore.fValue;
4690:       |                       ^~~~~~~~~~~
4691: /scratch/workspace/sbnd_ci/label_exp/swarm/label_exp2/swarm/SBND/srcs/sbncode/sbncode/CAFMaker/FillReco.cxx:927:23: error: request for member 'pid_ndof' in 'srlikepid', which is of non-class type 'int'
4692:   927 |             srlikepid.pid_ndof = AlgScore.fNdf;
4693:       |                       ^~~~~~~~
4694: /scratch/workspace/sbnd_ci/label_exp/swarm/label_exp2/swarm/SBND/srcs/sbncode/sbncode/CAFMaker/FillReco.cxx:930:23: error: request for member 'lambda_proton' in 'srlikepid', which is of non-class type 'int'
4695:   930 |             srlikepid.lambda_proton = AlgScore.fValue;
4696:       |                       ^~~~~~~~~~~~~
4697: /scratch/workspace/sbnd_ci/label_exp/swarm/label_exp2/swarm/SBND/srcs/sbncode/sbncode/CAFMaker/FillReco.cxx:931:23: error: request for member 'pid_ndof' in 'srlikepid', which is of non-class type 'int'
4698:   931 |             srlikepid.pid_ndof = AlgScore.fNdf;
4699:       |                       ^~~~~~~~
4700: /scratch/workspace/sbnd_ci/label_exp/swarm/label_exp2/swarm/SBND/srcs/sbncode/sbncode/CAFMaker/FillReco.cxx: In function 'void caf::FillTrackLikePID(const std::vector<art::Ptr<anab::ParticleID> >&, SRTrack&, bool)':
4701: /scratch/workspace/sbnd_ci/label_exp/swarm/label_exp2/swarm/SBND/srcs/sbncode/sbncode/CAFMaker/FillReco.cxx:948:47: error: 'class caf::SRTrack' has no member named 'likepid'
4702:   948 |         FillPlaneLikePID(particle_id, srtrack.likepid[p```

sungbinoh · 2025-11-18T15:07:19Z

Looks like a quick fix somewhere for this build error. Maybe a header file missing in the sbncode PR?

4672: /scratch/workspace/sbnd_ci/label_exp/swarm/label_exp2/swarm/SBND/srcs/sbncode/sbncode/CAFMaker/FillReco.h:230:62: error: 'caf::SRTrkLikelihoodPID' has not been declared
4673:   230 |   void FillPlaneLikePID(const anab::ParticleID &particle_id, caf::SRTrkLikelihoodPID &srlikepid);
4674:       |                                                              ^~~
4675: /scratch/workspace/sbnd_ci/label_exp/swarm/label_exp2/swarm/SBND/srcs/sbncode/sbncode/CAFMaker/FillReco.cxx:911:62: error: 'caf::SRTrkLikelihoodPID' has not been declared
4676:   911 |   void FillPlaneLikePID(const anab::ParticleID &particle_id, caf::SRTrkLikelihoodPID &srlikepid) {
4677:       |                                                              ^~~
4678: /scratch/workspace/sbnd_ci/label_exp/swarm/label_exp2/swarm/SBND/srcs/sbncode/sbncode/CAFMaker/FillReco.cxx: In function 'void caf::FillPlaneLikePID(const anab::ParticleID&, int&)':
4679: /scratch/workspace/sbnd_ci/label_exp/swarm/label_exp2/swarm/SBND/srcs/sbncode/sbncode/CAFMaker/FillReco.cxx:915:15: error: request for member 'setDefault' in 'srlikepid', which is of non-class type 'int'
4680:   915 |     srlikepid.setDefault();
4681:       |               ^~~~~~~~~~
4682: /scratch/workspace/sbnd_ci/label_exp/swarm/label_exp2/swarm/SBND/srcs/sbncode/sbncode/CAFMaker/FillReco.cxx:922:23: error: request for member 'lambda_muon' in 'srlikepid', which is of non-class type 'int'
4683:   922 |             srlikepid.lambda_muon = AlgScore.fValue;
4684:       |                       ^~~~~~~~~~~
4685: /scratch/workspace/sbnd_ci/label_exp/swarm/label_exp2/swarm/SBND/srcs/sbncode/sbncode/CAFMaker/FillReco.cxx:923:23: error: request for member 'pid_ndof' in 'srlikepid', which is of non-class type 'int'
4686:   923 |             srlikepid.pid_ndof = AlgScore.fNdf;
4687:       |                       ^~~~~~~~
4688: /scratch/workspace/sbnd_ci/label_exp/swarm/label_exp2/swarm/SBND/srcs/sbncode/sbncode/CAFMaker/FillReco.cxx:926:23: error: request for member 'lambda_pion' in 'srlikepid', which is of non-class type 'int'
4689:   926 |             srlikepid.lambda_pion = AlgScore.fValue;
4690:       |                       ^~~~~~~~~~~
4691: /scratch/workspace/sbnd_ci/label_exp/swarm/label_exp2/swarm/SBND/srcs/sbncode/sbncode/CAFMaker/FillReco.cxx:927:23: error: request for member 'pid_ndof' in 'srlikepid', which is of non-class type 'int'
4692:   927 |             srlikepid.pid_ndof = AlgScore.fNdf;
4693:       |                       ^~~~~~~~
4694: /scratch/workspace/sbnd_ci/label_exp/swarm/label_exp2/swarm/SBND/srcs/sbncode/sbncode/CAFMaker/FillReco.cxx:930:23: error: request for member 'lambda_proton' in 'srlikepid', which is of non-class type 'int'
4695:   930 |             srlikepid.lambda_proton = AlgScore.fValue;
4696:       |                       ^~~~~~~~~~~~~
4697: /scratch/workspace/sbnd_ci/label_exp/swarm/label_exp2/swarm/SBND/srcs/sbncode/sbncode/CAFMaker/FillReco.cxx:931:23: error: request for member 'pid_ndof' in 'srlikepid', which is of non-class type 'int'
4698:   931 |             srlikepid.pid_ndof = AlgScore.fNdf;
4699:       |                       ^~~~~~~~
4700: /scratch/workspace/sbnd_ci/label_exp/swarm/label_exp2/swarm/SBND/srcs/sbncode/sbncode/CAFMaker/FillReco.cxx: In function 'void caf::FillTrackLikePID(const std::vector<art::Ptr<anab::ParticleID> >&, SRTrack&, bool)':
4701: /scratch/workspace/sbnd_ci/label_exp/swarm/label_exp2/swarm/SBND/srcs/sbncode/sbncode/CAFMaker/FillReco.cxx:948:47: error: 'class caf::SRTrack' has no member named 'likepid'
4702:   948 |         FillPlaneLikePID(particle_id, srtrack.likepid[p```

Hi @nathanielerowe , yes, sbnanaobj PR168 should be merged first.

nathanielerowe · 2025-11-18T16:11:57Z

@sungbinoh The trigger build call included that PR

nathanielerowe · 2025-11-21T15:43:48Z

Don't know why github checkout failed for sbnanaobj on previous trigger build. Trying again with new tags.

nathanielerowe · 2025-11-21T15:47:23Z

trigger build LArSoft/lar*@LARSOFT_SUITE_v10_14_00 SBNSoftware/sbndaq-artdaq-core@v1_10_06 SBNSoftware/sbn*@SBN_SUITE_v10_14_00

FNALbuild · 2025-11-21T15:59:39Z

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

FNALbuild · 2025-11-21T16:03:26Z

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

FNALbuild · 2025-11-21T16:06:57Z

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

FNALbuild · 2025-11-21T16:39:01Z

⚠️ CI build for SBND Warning at phase ci_tests SBND on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

nathanielerowe · 2025-11-21T16:43:14Z

approved!

adding TrackChi2PidLabel to cafmakerjob fcl files

e0f0894

sungbinoh self-assigned this Oct 20, 2025

sungbinoh requested review from henrylay97 and justinjmueller October 20, 2025 17:22

sungbinoh added the caf Common analysis framework label Oct 20, 2025

sungbinoh requested a review from JosiePaton October 20, 2025 17:22

henrylay97 approved these changes Oct 21, 2025

View reviewed changes

sungbinoh changed the title ~~adding TrackChi2PidLabel to cafmakerjob fcl files~~ adding TrackLikePidLabel: to cafmakerjob fcl files Oct 21, 2025

nathanielerowe added this to SBND 2025 Fall Production Nov 17, 2025

nathanielerowe moved this to Reviewer Approved in SBND 2025 Fall Production Nov 17, 2025

Merge branch 'develop' into feature/sungbino_likepid_into_cafmaker

6171e8d

nathanielerowe moved this from Reviewer Approved to Flagged by CI in SBND 2025 Fall Production Nov 18, 2025

JosiePaton approved these changes Nov 19, 2025

View reviewed changes

Merge branch 'develop' into feature/sungbino_likepid_into_cafmaker

328e6b0

nathanielerowe moved this from Flagged by CI to RM Approved in SBND 2025 Fall Production Nov 21, 2025

Merge branch 'develop' into feature/sungbino_likepid_into_cafmaker

a50cd9c

nathanielerowe merged commit ccb6697 into SBNSoftware:develop Nov 21, 2025

nathanielerowe moved this from RM Approved to In tagged release in SBND 2025 Fall Production Nov 22, 2025

adding TrackLikePidLabel: to cafmakerjob fcl files #853

adding TrackLikePidLabel: to cafmakerjob fcl files #853

Uh oh!

Conversation

sungbinoh commented Oct 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Checklist

Relevant PR links (optional)

Link(s) to docdb describing changes (optional)

Uh oh!

justinjmueller commented Oct 20, 2025

Uh oh!

nathanielerowe commented Oct 29, 2025

Uh oh!

FNALbuild commented Oct 29, 2025

Uh oh!

FNALbuild commented Oct 29, 2025

Uh oh!

FNALbuild commented Oct 29, 2025

Uh oh!

FNALbuild commented Oct 29, 2025

Uh oh!

nathanielerowe commented Oct 29, 2025

Uh oh!

sungbinoh commented Oct 29, 2025

Uh oh!

nathanielerowe commented Oct 29, 2025

Uh oh!

nathanielerowe commented Nov 18, 2025

Uh oh!

FNALbuild commented Nov 18, 2025

Uh oh!

FNALbuild commented Nov 18, 2025

Uh oh!

FNALbuild commented Nov 18, 2025

Uh oh!

FNALbuild commented Nov 18, 2025

Uh oh!

nathanielerowe commented Nov 18, 2025

Uh oh!

FNALbuild commented Nov 18, 2025

Uh oh!

FNALbuild commented Nov 18, 2025

Uh oh!

FNALbuild commented Nov 18, 2025

Uh oh!

FNALbuild commented Nov 18, 2025

Uh oh!

nathanielerowe commented Nov 18, 2025

Uh oh!

sungbinoh commented Nov 18, 2025

Uh oh!

nathanielerowe commented Nov 18, 2025

Uh oh!

nathanielerowe commented Nov 21, 2025

Uh oh!

nathanielerowe commented Nov 21, 2025

Uh oh!

FNALbuild commented Nov 21, 2025

Uh oh!

FNALbuild commented Nov 21, 2025

Uh oh!

FNALbuild commented Nov 21, 2025

Uh oh!

FNALbuild commented Nov 21, 2025

Uh oh!

nathanielerowe commented Nov 21, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

sungbinoh commented Oct 20, 2025 •

edited

Loading