MeVPrtl LLP (fcls and files) #844
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jicrespo
requested changes
Oct 8, 2025
Member
There was a problem hiding this comment.
Remove from commit to avoid ROOT files in the repository
Member
There was a problem hiding this comment.
Remove from commit to avoid ROOT files in the repository
|
|
||
|
|
||
| #DECAY CONFIGS | ||
| decay_llp: { |
Member
There was a problem hiding this comment.
Maybe add a comment stating that the decay part is still work in progress and is not meant to be used (I see there are a lot of HNL-specific parameters there).
Contributor
|
@SabrinaBrickner Could you respond to some of these follow up q's? |
Member
|
For the record, this is an ongoing review and it is not required to converge for the Fall Production. @GaetanoFricano is also working on this. |
Contributor
|
Just checking in on this. Any updates? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds 5 files to the MevPrtl generator. 3 of these files are the fcls needed to run the new set of LLP modules, and the other 2 files contain the output of running the fcls with the new LLP tools.
Checklist
Reviewers,AssigneesDevelopementRelevant PR links (optional)
Does this PR require merging another PR in a different repository (such as sbnanobj/sbnobj etc.)?
Yes -> in sbncode it requires "MeVPrtl LLP (tools)"
Link(s) to docdb describing changes (optional)
Is there a docdb describing the issue this solves or the feature added?