Skip to content

Feature/acastill new pmt calibration#633

Merged
bear-is-asleep merged 6 commits intodevelopfrom
feature/acastill_newPMTCalibration
Feb 14, 2025
Merged

Feature/acastill new pmt calibration#633
bear-is-asleep merged 6 commits intodevelopfrom
feature/acastill_newPMTCalibration

Conversation

@asanchezcastillo
Copy link
Contributor

@asanchezcastillo asanchezcastillo commented Feb 12, 2025

Description

This is a temporary PR in preparation for the workshop production. This PR substitutes the PMT calibration obtained for OV5 (May-Dec 2024) to adjust to the new PMT operational voltajes (OV6, Dec-2024 now). This is a temporary solution until the calibration database is ready to be interfaced with the deconvolution module.
The PR also includes a modification to SBNDOpHitFinder to allow for a channel-dependent threshold. This is also a temporary solution. Definitive solution requires modifications to larana and will follow after larana PR #36 is merged.

This PR needs to be merged with a new version of sbnd_data contained at /exp/sbnd/app/users/acastill/Deconvolution/v10_03_01/srcs/sbnd_data

Checklist

  • Added at least 1 label from available labels.
  • Assigned at least 1 reviewer under Reviewers,
  • Assigned all contributers including yourself under Assignees
  • Linked any relevant issues under Developement
  • Does this PR affect CAF data format? If so, please assign a CAF maintainer (PetrilloAtWork or JosiePaton) as additional reviewer.
  • Does this affect the standard workflow?

Relevant PR links (optional)

Does this PR require merging another PR in a different repository (such as sbnanobj/sbnobj etc.)?

Link(s) to docdb describing changes (optional)

More information on docdb-39495

@asanchezcastillo asanchezcastillo added the reco1/reco2 Reconstruction label Feb 12, 2025
@asanchezcastillo asanchezcastillo requested review from absolution1, fjnicolas and linyan-w and removed request for fjnicolas February 12, 2025 14:56
@asanchezcastillo asanchezcastillo marked this pull request as ready for review February 12, 2025 14:57
@bear-is-asleep
Copy link
Contributor

trigger build SBNSoftware/sbncode@bugfix/hlay_mcs_invalid_read_pr LArSoft/lar*@LARSOFT_SUITE_v10_03_01 SBNSoftware/sbndaq-artdaq-core@v1_10_04

@FNALbuild
Copy link
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Collaborator

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link
Collaborator

⚠️ CI build for SBND Warning at phase ci_tests SBND on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

@bear-is-asleep
Copy link
Contributor

trigger build SBNSoftware/sbncode@bugfix/hlay_mcs_invalid_read_pr LArSoft/lar*@LARSOFT_SUITE_v10_03_01 SBNSoftware/sbndaq-artdaq-core@v1_10_04 SBNSoftware/sbncode@v10_03_01

@FNALbuild
Copy link
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Collaborator

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link
Collaborator

⚠️ CI build for SBND Warning at phase ci_tests SBND on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

@bear-is-asleep
Copy link
Contributor

Approved, changes are from sbncode develop

@bear-is-asleep bear-is-asleep merged commit a625eb4 into develop Feb 14, 2025
@asanchezcastillo asanchezcastillo deleted the feature/acastill_newPMTCalibration branch February 20, 2025 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

reco1/reco2 Reconstruction

Projects

Status: In tagged release

Development

Successfully merging this pull request may close these issues.

4 participants