Make flux calculator compatible with g4bnb flux #618
Conversation
marcodeltutto
requested review from
JosiePaton,
kjplows,
leoaliaga and
linyan-w
linyan-w
left a comment
linyan-w
left a comment
There was a problem hiding this comment.
Approved based on discussion.
|
trigger build LArSoft/lar*@LARSOFT_SUITE_v10_14_00 |
|
✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard |
|
❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c14:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build ICARUS phase logs parent CI build details are available through the CI dashboard |
|
❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build SBND phase logs parent CI build details are available through the CI dashboard |
|
✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard |
|
❌ CI build for ICARUS Failed at phase ci_tests ICARUS on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard 🚨 For more details about the failed phase, check the ci_tests ICARUS phase logs parent CI build details are available through the CI dashboard |
|
❌ CI build for SBND Failed at phase ci_tests SBND on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard 🚨 For more details about the failed phase, check the ci_tests SBND phase logs parent CI build details are available through the CI dashboard |
| int firstInelastic = 0; | ||
| while (dk2nu_v->at(inu).ancestor[firstInelastic].proc.find("HadronInelastic")==std::string::npos||dk2nu_v->at(inu).ancestor[firstInelastic].proc.find("QEBooNE")!=std::string::npos) firstInelastic++; | ||
|
|
||
| // Get the parent/ancestor (this should be the secondary in the p+Be interaction) |
There was a problem hiding this comment.
If we're aiming exclusively for the pBe secondary, you might also be able to find the first ancestor whose creation process includes "BooNEHadronInelastic:BooNEpBeInteraction", rather than just looking for the first inelastic interaction. I don't know myself exactly how much this affects things, how many first inelastic aren't the pBe interaction that's constrained in the above interaction type. It would leave the possibility that some neutrinos may never have that interaction type, but that would be a rare case.
|
Trying CI again as the failure modes were unrelated to the PR. |
|
trigger build LArSoft/lar*@LARSOFT_SUITE_v10_14_00 SBNSoftware/sbndcode@v10_14_00_01 |
|
✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard |
|
✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard |
|
❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c14:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build ICARUS phase logs parent CI build details are available through the CI dashboard |
|
❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build SBND phase logs parent CI build details are available through the CI dashboard |
|
❌ CI build for ICARUS Failed at phase ci_tests ICARUS on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard 🚨 For more details about the failed phase, check the ci_tests ICARUS phase logs parent CI build details are available through the CI dashboard |
|
🚨 For more details about the warning phase, check the ci_tests SBND phase logs parent CI build details are available through the CI dashboard |
kjplows
moved this from Partially reviewed
to Urgent checks
in SBN software development
Co-authored-by: John Plows kom.plows@gmail.com
…tware/sbncode into feature/mdeltutt_fluxweight_g4bnb
|
trigger build LArSoft/lar*@LARSOFT_SUITE_v10_14_00 SBNSoftware/sbndcode@v10_14_00_01 |
|
✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard |
|
✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard |
|
❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c14:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build ICARUS phase logs parent CI build details are available through the CI dashboard |
|
❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build SBND phase logs parent CI build details are available through the CI dashboard |
|
🚨 For more details about the warning phase, check the ci_tests SBND phase logs parent CI build details are available through the CI dashboard |
|
❌ CI build for ICARUS Failed at phase ci_tests ICARUS on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard 🚨 For more details about the failed phase, check the ci_tests ICARUS phase logs parent CI build details are available through the CI dashboard |
github-project-automation
bot
moved this from To merge
to Done
in SBN software development
linyan-w
moved this from Waiting on Reviewer
to In tagged release
in SBND 2025 Fall Production
Description
Makes the flux calculator for flux systematics compatible with G4BNB flux files in dk2nu format.