Skip to content

Conversation

@jamiecd
Copy link
Contributor

@jamiecd jamiecd commented Nov 13, 2025

Needed bc the charged pions comprise two components of the pions' isospin triplet. This change brings the code into agreement with the (correct) description of models as presented in MeVPrtl TN.

MeVPrtl TN is located at SBN-Doc-32019 (https://sbn-docdb.fnal.gov/cgi-bin/sso/ShowDocument?docid=32019).

Description

Please provide a detailed description of the changes this pull request introduces. If available, also link to a docdb link where the issue/change have been presented on/discussed.

  • Have you added a label? (bug/enhancement/physics etc.) Yes.
  • Have you assigned at least 1 reviewer? Yes.
  • Is this PR related to an open issue / project? No.
  • Does this PR affect CAF data format? If so, please assign a CAF maintainer as additional reviewer. No.
  • Does this PR require merging another PR in a different repository (such as sbnanobj/sbnobj etc.)? If so, please link it in the description. No.
  • Are you submitting this PR on behalf of someone else who made the code changes? If so, please mention them in the description. No.

…bc the charged pions comprise two components of the pions' isospin triplet.
@jamiecd jamiecd added the correction fix something newly found to be incorrect label Nov 13, 2025
Copy link
Contributor

@kjplows kjplows left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Matches formula at the end of Sect 4.1.2 of TN-32019. Approved!

@kjplows
Copy link
Contributor

kjplows commented Nov 20, 2025

trigger build LArSoft/lar*@LARSOFT_SUITE_v10_12_02

@FNALbuild
Copy link

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

@FNALbuild
Copy link

❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build ICARUS phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

@FNALbuild
Copy link

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link

❌ CI build for ICARUS Failed at phase ci_tests ICARUS on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the failed phase, check the ci_tests ICARUS phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link

⚠️ CI build for SBND Warning at phase ci_tests SBND on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

@kjplows kjplows moved this from Testing to To merge in SBN software development Nov 20, 2025
@kjplows kjplows merged commit 6d6dcbf into develop Nov 21, 2025
@github-project-automation github-project-automation bot moved this from To merge to Done in SBN software development Nov 21, 2025
@kjplows kjplows moved this from Done to Recently done in SBN software development Nov 21, 2025
@kjplows kjplows moved this from Recently done to Done in SBN software development Dec 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

correction fix something newly found to be incorrect

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants