-
Notifications
You must be signed in to change notification settings - Fork 40
Update Pandora track and shower discrimination scheme and training #840
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Update Pandora track and shower discrimination scheme and training #840
Conversation
| <UseICARUSCollectionPlane>true</UseICARUSCollectionPlane> | ||
| <MvaFileName>PFOCharBDT_v09_84_00_03_20250718_ICARUSCollection.xml</MvaFileName> | ||
| <MvaName>PFOCharBDT_v09_84_00_03_20250718_ICARUSCollection</MvaName> | ||
| <MvaFileNameNoChargeInfo>PFOCharBDT_v09_84_00_03_20250718_NoCharge.xml</MvaFileNameNoChargeInfo> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just curious - why are these in a separate file instead of putting both into one file as before? (wondering if just a choice or if there is a particular reason e.g.)
Also: checking, in the doc-db presentation you've given with the training results, were they prepared with these changes, so in some way this is already validated?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The two BDTs (with charge information and without it) came from two separate trainings, so I saved them into two separate XMLs. If you think it would be nicer to have them within a single XML, I can merge them! Thanks Bruce!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's probably fine either way.
This PR changes the Pandora XML (particularly, the
LArBdtPfoCharacterisationalgorithm) to accomodate for changes to the track/shower discrimination scheme, and to introduce the corresponding new BDT training files.Context
The code change within Pandora consists in choosing the Collection plane to compute calorimetric variables used in the track/shower discrimination BDT, instead of relying on the Induction-1 plane. Due to mapping technicalities, the Pandora
Wview (commonly mapped to Collection in other LArTPCs) is mapped to Induction-1 in ICARUS, whereas theUandVviews are mapped to Induction-2 or Collection, based on the TPC. For more details on the Pandora code change, check the corresponding PandoraPFA/LArContent PR #246, SBN DocDB 40882, and SBN DocDB 40375.The
UseICARUSCollectionPlanealgorithm parameter controls the plane used to determine whether charge information is available or not for the reconstructed particle (Collection iftrue), and as a result which BDT to use.Two ICARUS-specific tools are defined:
ConeChargeFeatureTool_ICARUS, andThreeDChargeFeatureTool_ICARUS. TheUseICARUSCollectionPlanetool parameter controls the plane used for computing charge-based variables (Collection iftrue).This modification was agreed with Pandora experts.
BDT re-training
Information on the BDT re-training are available on SBN DocDB 42432.
The track/shower BDT was re-trained with BNB MC samples based on
icaruscodev09_84_00_01, balanced between track and shower particles, and with "good reconstruction" cuts. The accuracy of the classification is shown to improve substantially across all particle types.Dependency
This PR needs the LArSoft/
larpandoracontentv04_16_00 release (LArSoft/larpandoracontent PR #78), i.e.,larsoftv10_08_02.It also needs the corresponding BDT XMLs added to
icarus_data: a newicarus_datarelease will be needed to pick up the right XMLs.After this PR is merged, the CAFMaker needs to be updated to pick up the newly-named tools. A companion PR in
sbncodewas opened (sbncode PR #546).Review
Tagging for review:
Also tagging @acampani as assignee.
Thanks!