Add Minecraft 1.8.9 support with complete rewrite #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Complete rewrite from Mixin-based to Forge event system - Add comprehensive JavaDoc documentation - Implement proper CTRL+Q functionality for hotbar and inventory - Fix version specification crash (removed invalid range syntax) - Update build system to Gradle 2.14 for 1.8.9 compatibility - Remove unnecessary dependencies and mixin framework - Streamline README with focus on macOS CMD+Q issue
- Extract magic numbers into named constants - Implement reflection field caching for better performance - Split large methods into focused helper functions - Add early returns to reduce nesting complexity - Eliminate code duplication with shared windowClick method - Remove unused initialization method - Improve code readability and maintainability
There was a problem hiding this comment.
Pull Request Overview
Adds first-time support for Minecraft 1.8.9 using Forge with a complete rewrite of the CTRL-Q mod from a Mixin-based to an event-based implementation.
- Replaces all Mixin configuration and classes with a single
CtrlQMod.javausing Forge events - Updates build scripts for Java 8/Gradle 2.14 and macOS CMD+Q handling
- Cleans up metadata (mcmod.info, README) and removes unused files (pack.mcmeta, old LICENSE)
Reviewed Changes
Copilot reviewed 15 out of 19 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/main/resources/pack.mcmeta | Removed unused asset pack metadata |
| src/main/resources/mcmod.info | Updated mod metadata (modid, name, URLs, authors, credits) |
| src/main/resources/ctrlq-forge.mixins.json | Removed obsolete Mixin configuration |
| All mixin Java files & CoreMod.java | Deleted old Mixin-based bootstrap and transformer code |
| src/main/java/me/polishkrowa/ctrlq/CtrlQMod.java | Added new Forge event–based implementation |
| settings.gradle | Simplified root project name |
| gradlew.bat, gradlew, gradle-wrapper.properties | Overhauled Gradle wrapper scripts and downgraded version |
| README.md | Rewritten installation, usage, and technical documentation |
| LICENSE (root & resources) | Removed existing license files |
Comments suppressed due to low confidence (4)
README.md:41
- [nitpick] Consider adding a migration or upgrade section to the README to guide users transitioning from the previous Mixin-based implementation to the new Forge event-based version.
MIT License
src/main/java/me/polishkrowa/ctrlq/CtrlQMod.java:293
- There are no tests for the new CTRL+Q functionality; consider adding unit or integration tests for handleHotbarCtrlQ and handleInventoryCtrlQ to ensure future changes don't regress core behavior.
}
gradle/wrapper/gradle-wrapper.properties:3
- You downgraded the Gradle wrapper from 6.8.3 to 2.14; ensure that all build scripts and plugins remain compatible with this older Gradle version or consider updating back to a more recent supported version.
distributionUrl=https\://services.gradle.org/distributions/gradle-2.14-bin.zip
| "mcversion": "1.8.9", | ||
| "url": "https://github.com/polishkrowa/Ctrl-Q", | ||
| "updateUrl": "", | ||
| "authorList": ["polishkrowa"], |
There was a problem hiding this comment.
[nitpick] The author name in authorList is all lowercase; consider using proper capitalization (e.g., "PolishKrowa") for consistency and readability.
Suggested change
| "authorList": ["polishkrowa"], | |
| "authorList": ["PolishKrowa"], |
|
|
||
| # Add default JVM options here. You can also use JAVA_OPTS and GRADLE_OPTS to pass JVM options to this script. | ||
| DEFAULT_JVM_OPTS="" | ||
| DEFAULT_JVM_OPTS='"-Xmx64m" "-Xms64m"' |
There was a problem hiding this comment.
The DEFAULT_JVM_OPTS variable includes embedded quotes, which may lead to double-quoting issues when launching the JVM; consider removing the inner quotes or adjusting the quoting so the JVM options are passed correctly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Key Changes
New Platform Support
Technical Improvements
PlayerController.windowClick()Code Quality
Test Plan
Breaking Changes
None - this is a new platform addition, not a replacement of existing functionality.