Updating DPP annotation description #31
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... based on experts review.
HeikoTheissen
suggested changes
Oct 22, 2024
Co-authored-by: Heiko Theißen <heiko.theissen@sap.com>
Co-authored-by: Heiko Theißen <heiko.theissen@sap.com>
Co-authored-by: Heiko Theißen <heiko.theissen@sap.com>
HeikoTheissen
approved these changes
Oct 23, 2024
ralfhandl
reviewed
Oct 23, 2024
ralfhandl
reviewed
Oct 23, 2024
ralfhandl
reviewed
Oct 23, 2024
ralfhandl
previously approved these changes
Oct 23, 2024
HeikoTheissen
approved these changes
Oct 23, 2024
pavelkornev
approved these changes
Nov 6, 2024
pavelkornev
requested changes
Nov 6, 2024
| "type": "boolean", | ||
| "default": true, | ||
| "description": "Property contains potentially personal data. Properties annotated with x-sap-dpp-field-semantics need not be additionally annotated with this extension." | ||
| "description": "Property contains potentially personal data. Properties annotated with x-sap-dpp-field-semantics need not be additionally annotated with this extension. Personal data describes any information which is related to an identified or identifiable natural person (data subject). An identifiable person is one who can be identified, directly or indirectly, in particular by a reference to an identifier such as a name, an identification number, location data, an online identifier, or to one or more factors specific to the physical, physiological, genetic, mental, economic, cultural, or social identity of that natural person." |
Member
There was a problem hiding this comment.
Please generate SAP schemas ! run npm run generate and commit those files to this PR. Thx.
Contributor
There was a problem hiding this comment.
@pavelkornev How about automating that step with a GitHub action?
Member
There was a problem hiding this comment.
Yeah, i think we should generate markdown files in general and have just one place where we define things, not 2.
pavelkornev
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... based on experts review.