fix(core): signalify skeleton and update jsdoc #13699
Conversation
droshev
added
enhancement
✅ Deploy Preview for fundamental-ngx ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
| * Unique ID for SVG mask element. | ||
| * @hidden | ||
| */ | ||
| protected readonly _id = `fd-skeleton-${skeletonUniqueId++}`; |
There was a problem hiding this comment.
This is not a private attr and should not be prefixed with underscore (it's used in the template).
| * Last line is 60% width when there are multiple lines. | ||
| * @hidden | ||
| */ | ||
| protected readonly _textLineWidths = computed(() => { |
There was a problem hiding this comment.
same for this one. It's used in the template. We prefix with underscore only private properties.
| const currentHeight = this.height(); | ||
|
|
||
| if (currentType === 'text') { | ||
| const lines = this.textLines() || 1; |
There was a problem hiding this comment.
This fallback to 1 should never be needed since textLines has a default value set to 3
| const lines = this.textLines() || 1; | ||
| return { | ||
| width: currentWidth ?? '100%', | ||
| height: currentHeight ?? (lines > 1 ? `${20 * lines}px` : '8px') |
There was a problem hiding this comment.
This magic number 20 can be a protected member of the class, say LINE_HEIGHT, which can also be used in the template (line 19).
|
Same comment as the one in title component PR. Maybe we sould replace the import of the module with the component import since we should encourage standalone now and we have deprecated the module. |
signalify skeleton and update jsdoc