fix(core): signalify title component #13698
Conversation
✅ Deploy Preview for fundamental-ngx ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
droshev
changed the title
| this._changeDetectorRef.detectChanges(); | ||
| if (title && !title.headerSize()) { | ||
| // Get the component instance's ComponentRef for setting signal inputs | ||
| const componentRef = (title as any)._componentRef as ComponentRef<TitleComponent>; |
There was a problem hiding this comment.
I am always a little worried when we have to do as any or any other type assertions.
Can we instead mark headerSize as model instead of input in the TitleComponent and do simply:
title.headerSize.set(5);
I, personally, find it easer to read. Also, that way we will preserve type safety. Do you see any drawbacks?
| } | ||
| }); | ||
| this._changeDetectorRef.detectChanges(); | ||
| this._changeDetectorRef.markForCheck(); |
There was a problem hiding this comment.
When you migrate to signal, please check if this is still needed?
There was a problem hiding this comment.
Can we migrate the dialog in a separate PR?
|
Just one more thing that I noticed - in the documentation we still encourage the user to use |
droshev
force-pushed
the
fix/title-signalize
branch
from
a808d19 to
dff66be
Compare
signalize and make zoneless title component, deprecate the module