fix(core): signalify text component #13696
Open
+312
−186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for fundamental-ngx ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
robertIsaac
reviewed
Jan 1, 2026
robertIsaac
approved these changes
Jan 1, 2026
…t test and copilot instructions
| Pellentesque a fermentum diam, eu fermentum enim. Phasellus faucibus risus id nisi faucibus, ac tempus nisi imperdiet. | ||
| Donec urna felis, ultricies vitae mauris at, convallis aliquet purus. Quisque vitae dapibus nisl, ultrices facilisis nisi. | ||
| Ut bibendum sed tortor eget pretium. Aenean dignissim nec sem non tempor.`; | ||
| protected readonly text = `Lorem ipsum dolor sit amet, consectetur adipiscing elit. Aliquam vestibulum justo non dui viverra mattis. Fusce venenatis tortor sit amet neque volutpat, eu mollis eros pulvinar. Duis sagittis aliquam lacus, quis tempor nisi vulputate et. Integer sagittis, metus ac hendrerit luctus, enim diam hendrerit nisl, et pretium turpis magna sed felis. Etiam volutpat condimentum justo at auctor. Sed imperdiet elementum ex, at semper metus vestibulum vitae. Quisque orci odio, tincidunt sed felis et, porta ultricies ligula. Etiam finibus, diam nec ultrices ultricies, odio nisi pretium augue, eget pharetra ipsum massa quis purus. Curabitur ante sapien, pharetra sed convallis non, vehicula nec leo. Fusce et elit aliquet, lobortis urna eu, porttitor eros.`; |
Member
There was a problem hiding this comment.
Why are these text variables all made readonly? Don't want the examples to give the impression that it's required
Contributor
Author
There was a problem hiding this comment.
what is wrong If the text is not going to change?
MariaIDineva
approved these changes
Jan 5, 2026
| <fd-text [text]="text" [maxLines]="3" [expandable]="true" [isCollapsed]="false"></fd-text> | ||
| <h3>Expandable text with two-way binding</h3> | ||
| <fd-text [text]="text" [maxLines]="3" [expandable]="true" [(isCollapsed)]="isCollapsed"></fd-text> | ||
| <p>Current state: {{ isCollapsed() ? 'Collapsed' : 'Expanded' }}</p> |
Contributor
There was a problem hiding this comment.
Do we need this p? It looks a little bit odd to me since the text above and the text below don't have it.
Contributor
Author
There was a problem hiding this comment.
above is the component (fd-text) and below is the headline for the next example h3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
signalify text component