chore: remove angular animations #13693
Conversation
robertIsaac
requested review from
InnaAtanasova,
droshev and
mikerodonnell89
as code owners
robertIsaac
force-pushed
the
chore/remove-angular-animations
branch
from
3f3259e to
1ba91f4
Compare
✅ Deploy Preview for fundamental-ngx ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
robertIsaac
force-pushed
the
chore/remove-angular-animations
branch
from
1ba91f4 to
a70a7dc
Compare
|
@robertIsaac can we merge this before even ng21? |
|
@droshev actually yes |
robertIsaac
force-pushed
the
chore/remove-angular-animations
branch
from
3acc3b9 to
a58c8ac
Compare
libs/cdk/utils/toast/classes/base-toast-animated-container.component.ts
Outdated
Show resolved
Hide resolved
libs/cdk/utils/toast/classes/base-toast-animated-container.component.ts
Outdated
Show resolved
Hide resolved
libs/cdk/utils/toast/classes/base-toast-animated-container.component.ts
Outdated
Show resolved
Hide resolved
libs/cdk/utils/toast/classes/base-toast-animated-container.component.ts
Outdated
Show resolved
Hide resolved
libs/core/dialog/dialog-container/dialog-container.component.ts
Outdated
Show resolved
Hide resolved
libs/core/message-box/message-box-container/message-box-container.component.ts
Show resolved
Hide resolved
since we don't need it anymore
robertIsaac
force-pushed
the
chore/remove-angular-animations
branch
2 times, most recently
from
64486ad to
9ffa4b9
Compare
robertIsaac
force-pushed
the
chore/remove-angular-animations
branch
from
9ffa4b9 to
cfa8645
Compare
| ></ng-template> | ||
| </ng-template> | ||
| <div class="fd-message-view"> | ||
| <div class="fdp-message-view"> |
There was a problem hiding this comment.
@robertIsaac the classes are always prefixed with fd- see
| <section | ||
| class="fd-message-view__list" | ||
| #listSection | ||
| class="fdp-message-view__list" |
|
@robertIsaac I will ask @InnaAtanasova, @MariaIDineva, and @mikerodonnell89 to look and once they approve we can merge it. |
mikerodonnell89
left a comment
mikerodonnell89
left a comment
There was a problem hiding this comment.
Something isn't working with the changes to the message box component, I'm no longer seeing the gradient fade-in
| @@ -0,0 +1,40 @@ | |||
| // Height collapse/expand animation using native CSS with custom properties | |||
There was a problem hiding this comment.
Correct me if I'm wrong but I'm not seeing this file being used anywhere?
|
|
||
| /** @hidden */ | ||
| @ViewChild('detailsSection', { read: ElementRef }) | ||
| protected _detailsSection: ElementRef; |
There was a problem hiding this comment.
I don't think this is used anywhere
There was a problem hiding this comment.
On the platform message popover component, I can no longer scroll the popover:
Also, drilling in to business information>company name, gives me this:
Screen.Recording.2026-01-02.at.3.08.16.PM.mov
Should look like this:
Screen.Recording.2026-01-02.at.3.09.32.PM.mov
|
@mikerodonnell89 @droshev I will make this as draft till we merge #13599 |
that is ok too. Thanks for that! we should be good in 1-2 weeks to go with Angular 21. |
Related Issue(s)
closes #13091
Description
replace @angular/animations with native css
this is due to it being deprecated
source
https://blog.angular.dev/angular-summer-update-2025-1987592a0b42#559f