Skip to content

Conversation

@MariaIDineva
Copy link
Contributor

@MariaIDineva MariaIDineva commented Dec 19, 2025

Related Issue(s)

part of #13176

Description

Certain webcomponents would extend other component classes and would depend on their properties, slots and methods. For example, SearchItemGroup would extend ListItemGroup where it would inherit its header-text property (in the wrapper that is headerText) from. In the custom elements json file that is displayed as (note the "superclass" property in the "declarations" array):

    {
      "kind": "javascript-module",
      "path": "dist/SearchItemGroup.js",
      "declarations": [
        {
          "kind": "class",
          "description": "The `ui5-search-item-group` is type of suggestion item,\nthat can be used to split the `ui5-search-item` suggestions into groups.",
          "name": "SearchItemGroup",
          "superclass": {
            "name": "ListItemGroup",
            "package": "@ui5/webcomponents",
            "module": "dist/ListItemGroup.js"
          },
          "tagName": "ui5-search-item-group",
          "customElement": true,
          "_ui5experimental": true,
          "_ui5since": "2.9.0",
          "_ui5privacy": "public"
        }
      ],
   ....
   }

This PR adds logic to our gerenator script to add all inherited properties, slots and methods to the components so that they are exposed and available to use. It does so by:

  • Adding a new function collectInheritedMembers which would recursively gather all that is inherited and pass it down to the componentTemplate generation logic.
  • Adding a new dependencyCemFiles property to the generate options in project.json that would point to the CEM file that the particular library depends on as some components might inherit components from a different package, eg. a component from ui5-webcomponents-fiori could extend a component from ui5-webcomponents,

@netlify
Copy link

netlify bot commented Dec 19, 2025

Deploy Preview for fundamental-ngx ready!

Name Link
🔨 Latest commit 4539209
🔍 Latest deploy log https://app.netlify.com/projects/fundamental-ngx/deploys/694c1f47613c8d0008efdff3
😎 Deploy Preview https://deploy-preview-13683--fundamental-ngx.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@MariaIDineva MariaIDineva self-assigned this Dec 19, 2025
@droshev droshev added this to the Sprint 153 - December 2025 milestone Dec 22, 2025
Copy link
Contributor

@droshev droshev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's go for it

@sap-email-compliance
Copy link

SAP employees are expected to use their SAP-email address for commits related to their work. Our compliance check has detected usage of an email other than a SAP one by a SAP employee. Please update your pull request accordingly.

If you think this is wrong or need any assistance, please contact ospo@sap.com.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants