16 blocking with threading #21
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing a new connection for each message. Added nack messages for some failures
2 tasks
2 tasks
jeremyestein
approved these changes
Dec 11, 2025
| return f"{datestring}.{csn}.{sourceSystem}.{units}.csv" | ||
| units = units.replace("/", "p") | ||
| units = units.replace("%", "percent") | ||
| return f"{datestring}.{csn}.{sourceStreamId}.{units}.csv" |
Collaborator
There was a problem hiding this comment.
Suggested change
| return f"{datestring}.{csn}.{sourceStreamId}.{units}.csv" | |
| // Will need to remove CSN from the pseudonymised version! | |
| return f"{datestring}.{csn}.{sourceStreamId}.{units}.csv" |
Collaborator
Author
There was a problem hiding this comment.
There's an issue for this #6, so I think it's not necessary to add a comment to code as well.
src/db.py
Outdated
Comment on lines
80
to
81
| obs_time_str = observation_time.strftime("%Y-%m-%d:%H:%M:%S") | ||
| start_time_str = start_time.strftime("%Y-%m-%d:%H:%M:%S") |
Collaborator
There was a problem hiding this comment.
Not a big deal but I'd expect the pg driver to accept datetime objects as parameters.
…xhaust the connections.
…tched csn file so we don't lose data yet'
Collaborator
Author
|
I couldn't get this worked reliably. Superceded by #24. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16 by putting the callback in a separate thread, so main thread can still get/send heartbeat to keep pika alive.
Fixes #17 by replacing characters in units string. (Also adds a unit test for this)
Adds some logic to send nack to rabbitMQ on some failures. This partially address #19 but may need more testing to find all failure modes.
Also updates the SQL to find the correct patients based on location visit times. This seems to be working on the GAE currently (subject to #20).
Limitations: most of the code does not have associated tests (low coverage) but it is tested by running on the GAE currently.