Conversation
|
Ping @BuckarooBanzay as you've made original changes. Any ideas for questions stated? Also fail / not fail with unknown things: mineunit is testing framework so excessive error/failure avoidance is of course bad thing, I think question is more about which way follows engine implementation better. |
Fail immediately would match with the current engine behavior
Not sure about that one, there are also some magic numbers (126 for air for example) but i'm not sure if/how they are translated into the game 🤷 |
|
Cleaned up, I think this is a lot more useful after mentioned things are done, currently seems to work like before without affecting behavior in any way. |
|
Bit deeper these things might actually matter, see comment #34 (comment) |
What added
Function
get_content_idwas added here: #13To be decided
As content ids get generated when you ask for one there should not be id available for name before using
minetest.get_content_id(name).This makes
minetest.get_name_from_content_id(cid)generate missing ids when called with unknown content id.Should
minetest.get_name_from_content_id(cid)fail immediately if called with unknown id?Also is content id 0 based or 1 based, probably 0 based (also used in original commit) is correct?