Open
Conversation
Owner
Author
|
HUD manipulation for spectator_mode breaks with 5.9.1 and above. Overall everything works a lot better with engine versions >= 5.4.1 and no changes from bare mineunit engine to 5.4.1 |
This was referenced Jun 22, 2025
Closed
fc3edf8 to
b15eae7
Compare
Click for detailed source code test coverage reportTest coverage 51.99% in 33/39 files:File Hits Missed Coverage
--------------------------------------------------------------
game/constants.lua 12 0 100.00%
voxelmanip.lua 214 2 99.07%
settings.lua 374 17 95.65%
game/privileges.lua 64 3 95.52%
craftmanager.lua 119 13 90.15%
core.lua 84 13 86.60%
assert.lua 191 32 85.65%
formspec.lua 166 34 83.00%
auth.lua 39 10 79.59%
craft.lua 93 24 79.49%
itemstack.lua 121 34 78.06%
entity.lua 64 22 74.42%
player.lua 332 130 71.86%
metadata.lua 177 80 68.87%
config.lua 63 35 64.29%
game/features.lua 21 12 63.64%
globals.lua 93 56 62.42%
game/register.lua 209 158 56.95%
fs.lua 5 4 55.56%
common/serialize.lua 55 44 55.56%
init.lua 118 97 54.88%
world.lua 83 85 49.40%
common/vector.lua 70 73 48.95%
server.lua 72 102 41.38%
game/auth.lua 38 68 35.85%
common/misc_helpers.lua 148 269 35.49%
game/misc.lua 42 87 32.56%
nodetimer.lua 12 25 32.43%
game/item.lua 142 331 30.02%
lib/json.lua 51 146 25.89%
common/chatcommands.lua 17 49 25.76%
game/chat.lua 150 593 20.19%
deprecation.lua 3 12 20.00%
scwd.lua 0 1 0.00%
protection.lua 0 12 0.00%
print.lua 0 66 0.00%
http.lua 0 60 0.00%
default/functions.lua 0 354 0.00%
common/after.lua 0 26 0.00%Mineunit stdout: |
Fix esplit last part, better form arg handling, fix and rename FS to Element Form allow type pattern: elementtype -> typepattern Better parsers and transformers Some optimization and utility methods Deferred formspec parsing
Signed-off-by: SX <50966843+S-S-X@users.noreply.github.com>
Co-authored-by: SX <50966843+S-S-X@users.noreply.github.com>
Co-authored-by: SX <50966843+S-S-X@users.noreply.github.com>
b15eae7 to
bd24105
Compare
Test coverage 51.99% in 33/39 files (higher is better).Dynamic debug coverage 26.33% in 25/39 files (lower is better). Click for detailed source code test coverage reportFile Hits Missed Coverage
--------------------------------------------------------------
game/constants.lua 12 0 100.00%
voxelmanip.lua 214 2 99.07%
settings.lua 374 17 95.65%
game/privileges.lua 64 3 95.52%
craftmanager.lua 119 13 90.15%
core.lua 84 13 86.60%
assert.lua 191 32 85.65%
formspec.lua 166 34 83.00%
auth.lua 39 10 79.59%
craft.lua 93 24 79.49%
itemstack.lua 121 34 78.06%
entity.lua 64 22 74.42%
player.lua 332 130 71.86%
metadata.lua 177 80 68.87%
config.lua 63 35 64.29%
game/features.lua 21 12 63.64%
globals.lua 93 56 62.42%
game/register.lua 209 158 56.95%
fs.lua 5 4 55.56%
common/serialize.lua 55 44 55.56%
init.lua 118 97 54.88%
world.lua 83 85 49.40%
common/vector.lua 70 73 48.95%
server.lua 72 102 41.38%
game/auth.lua 38 68 35.85%
common/misc_helpers.lua 148 269 35.49%
game/misc.lua 42 87 32.56%
nodetimer.lua 12 25 32.43%
game/item.lua 142 331 30.02%
lib/json.lua 51 146 25.89%
common/chatcommands.lua 17 49 25.76%
game/chat.lua 150 593 20.19%
deprecation.lua 3 12 20.00%
scwd.lua 0 1 0.00%
protection.lua 0 12 0.00%
print.lua 0 66 0.00%
http.lua 0 60 0.00%
default/functions.lua 0 354 0.00%
common/after.lua 0 26 0.00%Mineunit stdout: |
Use luassert formatter if dump is not available Add bytes to hex %X formatter Rework new formatters: %X to %x, %D to %@ with optional level 0-9 Expose formatter through mineunit.format function
noop: core.*objects_in* Move core.get_us_time
bd24105 to
2f6721f
Compare
Workflow update Luacheck exclude dot dirs Luacheck add mineunit.format
Form testing / dynamic debug documentation Documentation for custom formatters
Moved debughooks fallback to assert.lua Dynamic hooks disabled by default Rework stack pop/push Fix utils.noop for debughooks Update command line args
2f6721f to
cdc01f5
Compare
Test coverage 51.95% in 33/39 files (higher is better).Dynamic debug coverage 26.31% in 25/39 files (lower is better). Click for detailed source code test coverage reportFile Hits Missed Coverage
--------------------------------------------------------------
game/constants.lua 12 0 100.00%
voxelmanip.lua 214 2 99.07%
settings.lua 374 17 95.65%
game/privileges.lua 64 3 95.52%
craftmanager.lua 119 13 90.15%
core.lua 84 13 86.60%
assert.lua 191 32 85.65%
formspec.lua 166 34 83.00%
auth.lua 39 10 79.59%
craft.lua 93 24 79.49%
itemstack.lua 121 34 78.06%
entity.lua 64 22 74.42%
player.lua 332 130 71.86%
metadata.lua 177 80 68.87%
config.lua 63 35 64.29%
game/features.lua 21 12 63.64%
globals.lua 93 56 62.42%
game/register.lua 209 158 56.95%
fs.lua 5 4 55.56%
common/serialize.lua 55 44 55.56%
init.lua 118 97 54.88%
world.lua 83 85 49.40%
common/vector.lua 70 73 48.95%
server.lua 72 102 41.38%
game/auth.lua 38 68 35.85%
common/misc_helpers.lua 148 269 35.49%
game/misc.lua 42 87 32.56%
nodetimer.lua 12 25 32.43%
game/item.lua 142 331 30.02%
lib/json.lua 51 146 25.89%
common/chatcommands.lua 17 49 25.76%
game/chat.lua 150 593 20.19%
deprecation.lua 3 12 20.00%
scwd.lua 0 1 0.00%
protection.lua 0 12 0.00%
print.lua 0 70 0.00%
http.lua 0 60 0.00%
default/functions.lua 0 354 0.00%
common/after.lua 0 26 0.00%Mineunit stdout: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's included
%x(hex dump) and%@(source file+line).Basic smoke tests
Engine version mineunit
Engine version 5.4.1
Engine version 5.5.1
Engine version 5.6.1
Engine version 5.7.0
Engine version 5.8.0
Engine version 5.9.1
Engine version 5.10.0
Engine version 5.11.0