Open
Conversation
…ss code duplication with batched events coming up
…z/django-sendgrid into feature/batch_sendgrid_events Conflicts: sendgrid/tests.py sendgrid/views.py
…z/django-sendgrid into feature/batch_sendgrid_events Conflicts: sendgrid/views.py
…z/django-sendgrid into feature/batch_sendgrid_events
…go way to do this already but I couldn't find it
… test if SENDGRID_CREATE_EVENTS_AND_EMAILS_FOR_NEWSLETTERS = True
sendgrid/utils/__init__.py
Outdated
Owner
There was a problem hiding this comment.
What about building an intermediate flattened dict?
Subkeys like ["foo"]["bar"] become ["foo["bar"]], since that's the same format you're expecting AFAIK. The nesting will never go past two levels, right? Seems more straightforward to manipulate data structures and not as fragile… ?
added 7 commits
December 10, 2012 12:24
…d event at top level
added 29 commits
December 31, 2012 15:38
This reverts commit bf79b2e.
…h an email message does not exists
…l fail or all succeed
…the transaction to avoid race conditions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added support for batched events.
Also contains some initial refactoring for newsletter event behaviour.
The handling of json or form data could probably be cleaner.