Skip to content

Conversation

@Maxr1998
Copy link
Contributor

This adds the duration of each top track/recording in the year in music report.

Fixes #1008.

Example

image

@Maxr1998
Copy link
Contributor Author

Maxr1998 commented Dec 28, 2025

I'm still pretty unhappy with the code, especially the duplicated logic in the recording and track formatters. Moreover, since this touches some core parts of alistral, I'm unsure whether my chosen way to make this optional and only active in YIM is ideal. Definitely open to suggestions here.

@RustyNova016
Copy link
Owner

Code wise, it's fine IMO. Would need a rebase on the new top printer but by using a builder pattern it should be fine.

What I struggle with is how the duration is shown. Right now it looks like a disambiguation on the artist credit.

Although I don't really have any other ideas for where to put it instead. I need to checkout the branch and try out stuff.

One thing for sure is that I'd probably put it behind a cli flag as it can make the title more verbose

@Maxr1998
Copy link
Contributor Author

Many good arguments. I'll give it a rebase and fix any issues, then you can have a look at it and experiment a bit.

@Maxr1998 Maxr1998 force-pushed the recording-duration branch 2 times, most recently from e3fa9a7 to 96b7481 Compare January 1, 2026 12:06
This adds the duration of each top track/recording in the year in music report.
@Maxr1998 Maxr1998 force-pushed the recording-duration branch from 96b7481 to 3128b3f Compare January 1, 2026 12:13
@Maxr1998 Maxr1998 marked this pull request as ready for review January 1, 2026 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Show duration of recordings on recording tops

2 participants