ml-dsa: lower stack size of KeyGen::from_seed by up to 207kb#1261
Open
baloo wants to merge 1 commit intoRustCrypto:masterfrom
Open
ml-dsa: lower stack size of KeyGen::from_seed by up to 207kb#1261baloo wants to merge 1 commit intoRustCrypto:masterfrom
baloo wants to merge 1 commit intoRustCrypto:masterfrom
Conversation
This reworks the API to make KeyGen::from_seed return a `SeededSigningKey` instead of a `KeyPair`. The `SeededSigningKey` effectively replaces the `KeyPair`, and instead of eagerly generating the VerifyingKey (implementing `signature::KeypairRef`), it implements `signature::Keypair` and makes the verifying key when requested. This reduces the depth of the stack when calling from_seed and reduces the size of the stack by 207kb using ML-DSA-87 in debug/tests builds (the heaviest consumers). This is an API break.
baloo
force-pushed
the
baloo/push-qvmpxpnrrwys
branch
from
9a3dfdd to
c3230e4
Compare
Member
Author
|
This lowers the stack size by 136kB in release mode (ML-DSA-87). |
Member
Author
|
cc @mgodf89 |
Member
Author
|
Tested this and #1259 in a fairly large repository and that fixed our immediate issues with stack sizes (we had stack overflows in the test suite). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reworks the API to make KeyGen::from_seed return a
SeededSigningKeyinstead of aKeyPair.The
SeededSigningKeyeffectively replaces theKeyPair, and instead of eagerly generating the VerifyingKey (implementingsignature::KeypairRef), it implementssignature::Keypairand makes the verifying key when requested.This reduces the depth of the stack when calling from_seed and reduces the size of the stack by 207kb using ML-DSA-87 in debug/tests builds (the heaviest consumers).
This is an API break.
See #1024