fix: remove rust-toolchain.toml to avoid forcing toolchain on all developers #819
+3
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…elopers PR #814 added rust-toolchain.toml for Nix flake support, but this file affects all developers using rustup, not just Nix users. The pinned version (1.91) is outdated and conflicts with CI which tests against stable/beta/nightly. This change: - Removes rust-toolchain.toml - Updates flake.nix to specify stable Rust directly using rust-overlay - Keeps Nix-specific config in Nix files without affecting other devs
Member
Should we not test CI against a single known version? Right now every PR tends to have to fix the latest new clippy issues. On the other hand it does spread the load of dealing with new clippy lints 😆 Let me know what you think (I've no serious objection against CI running against the world) |
yara-blue
reviewed
Dec 24, 2025
| system: let | ||
| pkgs = inputs.nixpkgs.legacyPackages.${system}.extend inputs.rust-overlay.overlays.default; | ||
| rust = pkgs.rust-bin.fromRustupToolchainFile ./rust-toolchain.toml; | ||
| rust = pkgs.rust-bin.stable.latest.default.override { |
Member
There was a problem hiding this comment.
should be a specific version and not just latest stable, otherwise the project is not reproducible.
Member
There was a problem hiding this comment.
let me know if you dont use nix yourselves though
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #814 added
rust-toolchain.tomlfor Nix flake support, but this file affects all developers using rustup, not just Nix users. The pinned version (1.91) is outdated and conflicts with CI which tests against stable/beta/nightly.This change:
rust-toolchain.tomlflake.nixto specify stable Rust directly usingrust-overlay