Implement configuration #32
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Etheryen
requested changes
Apr 20, 2025
Contributor
Etheryen
left a comment
Etheryen
left a comment
There was a problem hiding this comment.
One nit, z-index of options menu is wrong (displayed behind the VM), keyboard inputs falling-through while typing text inside the options seems to be unwanted behavior. Other than that, the debug-mode option making the debug-mode not enabled, but barely available is a bit unnatural, unless there is a reason for that.
src/config/mod.rs
Outdated
| let file_contents = | ||
| fs::read_to_string(path).map_err(|_| ConfigError::NotReadable)?; | ||
|
|
||
| match toml::from_str(&file_contents) { |
Contributor
There was a problem hiding this comment.
Nit:
toml::from_str(&file_contents)
.map_err(|_| ConfigError::InvalidFileFormat)is more idiomatic
…o current state after closing options window
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.