-
Notifications
You must be signed in to change notification settings - Fork 246
fix: add OpenCode slash command discovery and execution support #568
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
chr1syy
wants to merge
5
commits into
RunMaestro:0.16.0-RC
Choose a base branch
from
chr1syy:fix-opencode-slash-commands
base: 0.16.0-RC
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+289
−19
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
0ab51f1
fix: add OpenCode slash command discovery and execution support
chr1syy 0a05d4d
test: update slash command discovery test for OpenCode support
chr1syy f52b59c
fix: guard against array values in OpenCode command config parsing
chr1syy c271453
fix: address PR review feedback for OpenCode slash command discovery
chr1syy c83a23e
fix: handle malformed opencode.json gracefully in slash command disco…
chr1syy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
JSON parse errors silently kill all command discovery
JSON.parse(content)throws aSyntaxErrorfor malformed JSON. ASyntaxErrorhas no.codeproperty, soerror?.code === 'ENOENT'evaluates tofalseand the error is re-thrown. Since bothaddCommandsFromConfigcalls run insidePromise.all, a single malformedopencode.json(e.g. a stray trailing comma or an unquoted key) causes the entirediscoverOpenCodeSlashCommandsto reject — wiping out the built-in commands that were already collected intocommands.The practical impact: a user with any typo in their
opencode.jsonwill see zero slash-command autocomplete instead of the seven built-in commands they should always get.The same pattern applies to both the project-level and global
opencode.jsonpaths read on lines 92–93.