Draft
Conversation
Co-authored-by: hailer <hailer@berea.edu>
|
Cursor Agent can help with this pull request. Just |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix game logic, stability, and portability issues by improving card handling, war resolution, and adding a missing include.
The war resolution logic was particularly problematic. Previously, if a player ran out of cards mid-war, the game would print an error and return, leaving game state inconsistent and potentially unresolvable. The fix now ensures that if one player can continue, they win the current pot and remaining cards, and if neither can continue, all piles are cleared for a clean game end. This prevents deadlocks and ensures proper game termination. The
NO_CARDsentinel addresses a subtle logic error where0(a valid card) was used to indicate no cards, leading to incorrect comparisons and game outcomes during ties or war.