Conversation
Owner
|
Hi! I'm just gonna write this here once, instead of on every PR: Thank you very much for submittimg your changes here instead of just quietly using them yourself. I will try to review them as soon as I can. In the meantime, just kindly make sure your changes don't break any inputs of asm dialects that were supported before. I'm not actually sure the tests are enough for that, so some manual testing won't hurt. |
Contributor
Author
|
Hi, thank you very much! I did a couple manual checks with a few examples longer examples found online, in x86 and ARM64, and everything seems to be the same (and even less errors in ARM64). |
Owner
|
Thanks again for all your contributions! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, here is a small fix to make ARMv7 addresses compatible.
For
LDR A1, =addr:Before:
After:
Thank you very much for this great project! I apologize for opening so many PRs in a short amount of time, but I already had a few changes done, and thought it would be best to have different changes in different PRs. Please let me know if there are any changes/improvements you would like me to make.