Skip to content

V0rubibook#3

Open
denverbaumgartner wants to merge 11 commits intomasterfrom
v0rubibook
Open

V0rubibook#3
denverbaumgartner wants to merge 11 commits intomasterfrom
v0rubibook

Conversation

@denverbaumgartner
Copy link
Contributor

adds a simple RubiconLiquidityVenue following the GenericLiquidityVenue pattern with the option to subscribeToBookUpdates every block, connected through a ethers.providers.WebSocketProvider 📟 some thoughts about where we should go from here outlined in the comments 🌶️

@bghughes
Copy link
Contributor

bghughes commented Apr 16, 2023

adds a simple RubiconLiquidityVenue following the GenericLiquidityVenue pattern with the option to subscribeToBookUpdates every block, connected through a ethers.providers.WebSocketProvider 📟 some thoughts about where we should go from here outlined in the comments 🌶️

One thing I noticed is this startServer script seems unsupported, some changes that I think are required:

  • A callable script via package.json and liquidityVenues/rubicon/index.ts that prints out the liveBook feed to verify its tracking is correct or incorrect
  • Generally @denverbaumgartner could you keep those comments to GH? I see the large mass of thoughts in comments which is fine but we will want those removed from the repo and better as GH comments or issues so people can iterate and reference them ideally

I like the utility wrapped for the contracts a lot, nice work on this 💯

@denverbaumgartner
Copy link
Contributor Author

updated startServer script to subscribe to a live book utilizing the pattern npm run startServer <chainID> <asset symbol> <quote symbol> - example: npm run startServer 10 WETH USDC. now uses v2 view functions to retrieve the book, removing two unnecessary calls. should be ready to go, let me know if there are any iterations that can improve this 🫡

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants