You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
adds a simple RubiconLiquidityVenue following the GenericLiquidityVenue pattern with the option to subscribeToBookUpdates every block, connected through a ethers.providers.WebSocketProvider 📟 some thoughts about where we should go from here outlined in the comments 🌶️
adds a simple RubiconLiquidityVenue following the GenericLiquidityVenue pattern with the option to subscribeToBookUpdates every block, connected through a ethers.providers.WebSocketProvider 📟 some thoughts about where we should go from here outlined in the comments 🌶️
One thing I noticed is this startServer script seems unsupported, some changes that I think are required:
A callable script via package.json and liquidityVenues/rubicon/index.ts that prints out the liveBook feed to verify its tracking is correct or incorrect
Generally @denverbaumgartner could you keep those comments to GH? I see the large mass of thoughts in comments which is fine but we will want those removed from the repo and better as GH comments or issues so people can iterate and reference them ideally
I like the utility wrapped for the contracts a lot, nice work on this 💯
updated startServer script to subscribe to a live book utilizing the pattern npm run startServer <chainID> <asset symbol> <quote symbol> - example: npm run startServer 10 WETH USDC. now uses v2 view functions to retrieve the book, removing two unnecessary calls. should be ready to go, let me know if there are any iterations that can improve this 🫡
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adds a simple
RubiconLiquidityVenuefollowing theGenericLiquidityVenuepattern with the option tosubscribeToBookUpdatesevery block, connected through aethers.providers.WebSocketProvider📟 some thoughts about where we should go from here outlined in the comments 🌶️