This repository was archived by the owner on Aug 20, 2025. It is now read-only.
Update README.md + fix parsing segment#12
Open
KirianCaumes wants to merge 2 commits intoRovoMe:masterfrom
Open
Update README.md + fix parsing segment#12KirianCaumes wants to merge 2 commits intoRovoMe:masterfrom
KirianCaumes wants to merge 2 commits intoRovoMe:masterfrom
Conversation
Author
|
Commit 03ca911 fixes a bug occuring when a segment name contains a dot, which breaks the rest of the parsing (ex: "Party id. identification" , see https://service.unece.org/trade/untdid/d96a/trsd/trsdnad.htm). All tests still work: |
KirianCaumes
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some (humble) corrections and add to the
README.me.I know that some of these additions would have greatly helped me understand
ts-edifactmore quickly.Don't hesitate to tell me what you think.
Thanks for your work
ps: it seems that the last validated PR #11 was never pushed to NPM, it would be great if that could be the case 😉