Merged
Conversation
modificação das respostas das atividades para a nova versão;
modificação das respostas das atividades para a nova versão;
There was a problem hiding this comment.
Copilot reviewed 34 out of 34 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (3)
app/src/main/java/com/routinely/routinely/task/EditTaskScreen.kt:134
- Ensure that initialTask.date always follows the 'yyyy-MM-dd HH:mm' format to prevent potential runtime parsing errors.
val dateTime = LocalDate.parse(initialTask.date, dateTimeFormatter)
app/src/main/java/com/routinely/routinely/home/HomeScreen.kt:68
- [nitpick] Consider removing the unused variable 'temporaryDeleteId' to clean up dead code if it is not required.
val temporaryDeleteId by remember { mutableStateOf<TaskItem?>(null) }
app/src/main/java/com/routinely/routinely/task/AddTaskScreen.kt:234
- Consider enforcing validation on taskDate and taskTime so that formattedDate is not an empty string, which could lead to API errors.
val formattedDate = if (taskDate.isNotEmpty() && taskTime.isNotEmpty()) { "$taskDate $taskTime" } else { "" }
| ApiResponse.DefaultError | ||
| } | ||
| } catch (e: Exception) { | ||
| println("Erro ao processar resposta: ${e.message}") |
There was a problem hiding this comment.
[nitpick] Replace the println statement with a proper logging mechanism (e.g. Timber) to ensure consistent and production-ready error logging.
Suggested change
| println("Erro ao processar resposta: ${e.message}") | |
| Timber.e(e, "Erro ao processar resposta") |
Collaborator
There was a problem hiding this comment.
Eu ia falar isso, mas ele falou antes kkkk. Tbm recomendo usar o Timber, talvez o Timber.d e continuar a msg + o erro como estava antes ou como ele recomendou, vc que sabe.
OdisBy
approved these changes
Apr 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.










Issue
This pull request refers to Issue #
Description
Please include a summary of the change and which issue is fixed.
Types of changes
What changed:
Checklist
develop(if not - rebase it or merge it).If any of the acceptance criteria are not met, please explain why below
What is the criteria? Why it is different?