Skip to content

Feat/update add task screen#109

Merged
CroyzCamel merged 8 commits intodevelopfrom
feat/update-add-task-screen
Apr 14, 2025
Merged

Feat/update add task screen#109
CroyzCamel merged 8 commits intodevelopfrom
feat/update-add-task-screen

Conversation

@CroyzCamel
Copy link
Contributor

Issue

This pull request refers to Issue #

  • Does not apply to this pull request

Description

Please include a summary of the change and which issue is fixed.

Types of changes

  • New feature (non-breaking change which adds functionality).
  • [x} Bug fix (non-breaking change which fixes an issue).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).

What changed:

  • UI
  • Business rule
  • Documentation
  • Gradle or Build
  • Navigation
  • Tests
  • Resource files
  • Project architecture
  • Code style

Checklist

  • Have tested the changes.
  • Met all the acceptance requirements of this task.
  • Verified if branch is up-to-date with develop (if not - rebase it or merge it).
  • Resolve git conflicts

If any of the acceptance criteria are not met, please explain why below

What is the criteria? Why it is different?

@CroyzCamel CroyzCamel requested a review from OdisBy April 12, 2025 20:54
@CroyzCamel CroyzCamel self-assigned this Apr 12, 2025
@CroyzCamel CroyzCamel added the bug Something isn't working label Apr 12, 2025
@OdisBy OdisBy requested a review from Copilot April 14, 2025 13:15
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 34 out of 34 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (3)

app/src/main/java/com/routinely/routinely/task/EditTaskScreen.kt:134

  • Ensure that initialTask.date always follows the 'yyyy-MM-dd HH:mm' format to prevent potential runtime parsing errors.
val dateTime = LocalDate.parse(initialTask.date, dateTimeFormatter)

app/src/main/java/com/routinely/routinely/home/HomeScreen.kt:68

  • [nitpick] Consider removing the unused variable 'temporaryDeleteId' to clean up dead code if it is not required.
val temporaryDeleteId by remember { mutableStateOf<TaskItem?>(null) }

app/src/main/java/com/routinely/routinely/task/AddTaskScreen.kt:234

  • Consider enforcing validation on taskDate and taskTime so that formattedDate is not an empty string, which could lead to API errors.
val formattedDate = if (taskDate.isNotEmpty() && taskTime.isNotEmpty()) { "$taskDate $taskTime" } else { "" }

ApiResponse.DefaultError
}
} catch (e: Exception) {
println("Erro ao processar resposta: ${e.message}")
Copy link

Copilot AI Apr 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Replace the println statement with a proper logging mechanism (e.g. Timber) to ensure consistent and production-ready error logging.

Suggested change
println("Erro ao processar resposta: ${e.message}")
Timber.e(e, "Erro ao processar resposta")

Copilot uses AI. Check for mistakes.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eu ia falar isso, mas ele falou antes kkkk. Tbm recomendo usar o Timber, talvez o Timber.d e continuar a msg + o erro como estava antes ou como ele recomendou, vc que sabe.

@CroyzCamel CroyzCamel added this pull request to the merge queue Apr 14, 2025
Merged via the queue into develop with commit 5e668b4 Apr 14, 2025
1 check passed
@CroyzCamel CroyzCamel deleted the feat/update-add-task-screen branch April 14, 2025 23:09
@MarcosNazario
Copy link

Teste realizado, permitindo navegar pelas telas de criação de atividade, seja "Tarefa" ou "Hábito", porém não possíbilita a conclusão da jornada. Ao tentar finalizar a jornada, clicando em "Adicionar tarefa", é exibida mensagem de erro, seguem abaixo as evidências:

Screenshot_20250514_183302_Routinely
Screenshot_20250514_183313_Routinely
Screenshot_20250514_183330_Routinely
Screenshot_20250514_183342_Routinely
Screenshot_20250514_183504_Routinely
Screenshot_20250514_183514_Routinely
Screenshot_20250514_183557_Routinely
Screenshot_20250514_183732_Routinely
Screenshot_20250514_183753_Routinely
Screenshot_20250514_183818_Routinely

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants