Add search path for rfd3 configurations #147
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a Hydra search path entry for rfd3-specific configurations, enabling the inference configuration to locate model-specific config files within the rfd3.configs package before falling back to the shared configs directory.
- Adds
pkg://rfd3.configsto the Hydra searchpath in the inference configuration - Maintains the existing
pkg://configsas a fallback for shared configurations
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
|
looks good -- do we need to do this for rf3 too? |
Collaborator
Author
|
I don't know @r-krishna but we could add it for the rf3 configs too @copilot |
Contributor
|
@Ubiquinone-dot I've opened a new pull request, #166, to work on those changes. Once the pull request is ready, I'll request review from you. |
* Initial plan * Add search path for rf3 configurations Co-authored-by: Ubiquinone-dot <66851659+Ubiquinone-dot@users.noreply.github.com> * Add rfd3 searchpath to validate.yaml and dev.yaml Co-authored-by: Ubiquinone-dot <66851659+Ubiquinone-dot@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: Ubiquinone-dot <66851659+Ubiquinone-dot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To address #144