Run clang-format on all source files#330
Closed
lczech wants to merge 1 commit intoRosettaCommons:masterfrom
Closed
Run clang-format on all source files#330lczech wants to merge 1 commit intoRosettaCommons:masterfrom
lczech wants to merge 1 commit intoRosettaCommons:masterfrom
Conversation
Member
|
Thank you @lczech ! The diff set looks a bit off (should be just a few changes at best since last merge to master), - maybe merge-in latest master? |
Author
Member
|
Yes, - sorry about that! I reformatted and merged before I saw your PR. Probably best to close this for now. Please feel free to re-open if you still see local diffs after reformatting. |
Author
|
Sure, thanks! Now you closed and immediately re-opened this. Shall we close it? Or what is your plan? |
Member
|
🤦♂️ - yes, please close (ie it is your PR) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following up on #329 (comment)
This PR is just the result of calling
clang-format -i *.hppandclang-format -i *.cppin thesourcedirectory, with clang format v18.1.3 on Ubuntu 24.