add support for arbitrary nested namespaces#312
Open
mattangus wants to merge 1 commit intoRosettaCommons:masterfrom
Open
add support for arbitrary nested namespaces#312mattangus wants to merge 1 commit intoRosettaCommons:masterfrom
mattangus wants to merge 1 commit intoRosettaCommons:masterfrom
Conversation
lyskov
reviewed
Jan 31, 2025
Member
lyskov
left a comment
lyskov
left a comment
There was a problem hiding this comment.
Thank you for putting this together @mattangus ! Could you please elaborate on why this PR is needed, ie what exactly does not work properly in current version of the code? Maybe add minimal header-file-snippet to PR description that will trigger errors/wrong-behavior?
Thanks,
| } | ||
|
|
||
| res.push_back (s.substr (pos_start)); | ||
| return res; |
Member
There was a problem hiding this comment.
Could you please say a few words why do you want to rewrite this function? Thanks,
Author
|
I wrote this code a while ago but just never got around to making the PR. I did find an edge case but I can't remember what it is now. I've run the new test that I created on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for arbitrary nesting of namespaces (any number of nested levels).
This PR updates the template code and I'm not sure how you would like me to deal with the reference files in the test folder. Should I replace everything? The tests still pass because the
--always-successflag is enabled.