Skip to content

Conversation

@rienmack
Copy link

No description provided.

Copy link

@jorbascrumps jorbascrumps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some thoughts!

@rienmack rienmack requested a review from tszulc May 28, 2025 14:09
@tszulc
Copy link
Member

tszulc commented Sep 16, 2025

We should also think about adding a foreign key to the user_id column. I guess that would also require making it an unsigned int...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Legacy class based implementation

Doesn't look like we use it ourselves, but we may as well keep supporting it if the base repo does too.

Copy link
Member

@tszulc tszulc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good! 👍

@rienmack
Copy link
Author

LGTM 🔥🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants