-
Notifications
You must be signed in to change notification settings - Fork 0
feat: ip tracking #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
745ff8f to
dcf05b2
Compare
jorbascrumps
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some thoughts!
ee8b9d0 to
aaed8ef
Compare
aaed8ef to
d504bf4
Compare
src/migrations/2025_04_16_203449_add_ip_field_to_revisions_table.php
Outdated
Show resolved
Hide resolved
|
We should also think about adding a foreign key to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Legacy class based implementation
Doesn't look like we use it ourselves, but we may as well keep supporting it if the base repo does too.
tszulc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good! 👍
|
LGTM 🔥🚀 |
No description provided.