Skip to content

chore: remove XML tool calling support #10841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mrubens merged 17 commits into from
Jan 21, 2026
+1,847 −14,964
Merged

chore: remove XML tool calling support #10841

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
2558400
chore: remove XML tool calling support
hannesrudolph Jan 20, 2026
ca8a818
chore: remove unused prompt tool description files
hannesrudolph Jan 20, 2026
be5bcbc
fix: add missing list_files and new_task case handlers in NativeToolC…
hannesrudolph Jan 20, 2026
7f4955e
fix: address PR review feedback
hannesrudolph Jan 20, 2026
c577eca
fix: harden streaming tool-call finalization and list_files args
hannesrudolph Jan 20, 2026
725bd33
test: fix validateToolUse mocks for isValidToolName
hannesrudolph Jan 20, 2026
8fba7fc
chore: remove remaining Bedrock non-native tool conversion
hannesrudolph Jan 20, 2026
8d4472a
fix: always include tools from metadata; remove supportsNativeTools
hannesrudolph Jan 20, 2026
76eff25
test: stabilize vscode-lm getModel expectations
hannesrudolph Jan 20, 2026
c718278
chore: simplify useNativeTools checks across providers
daniel-lxs Jan 20, 2026
7707dc5
simplify: always add fine-grained-tool-streaming beta for Claude mode…
daniel-lxs Jan 20, 2026
7fa89eb
refactor: remove unnecessary tools?.length conditional checks from AP…
daniel-lxs Jan 20, 2026
6bbbccb
chore: remove dead xmlInfo code and fix misleading test name
daniel-lxs Jan 20, 2026
5c3ac63
fix: revert parallel_tool_calls behavior to only send when explicitly…
daniel-lxs Jan 20, 2026
95812a0
fix: restore parallel_tool_calls default behavior
daniel-lxs Jan 20, 2026
963e372
fix: update remaining test files for parallel_tool_calls assertions
daniel-lxs Jan 20, 2026
441f797
Merge branch 'main' into chore/remove-xml-tool-calling
mrubens Jan 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 0 additions & 46 deletions apps/web-evals/src/app/runs/new/new-run.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,6 @@ import { useRooCodeCloudModels } from "@/hooks/use-roo-code-cloud-models"

import {
Button,
Checkbox,
FormControl,
FormField,
FormItem,
Expand Down Expand Up @@ -111,7 +110,6 @@ export function NewRun() {

const [provider, setModelSource] = useState<"roo" | "openrouter" | "other">("other")
const [executionMethod, setExecutionMethod] = useState<ExecutionMethod>("vscode")
const [useNativeToolProtocol, setUseNativeToolProtocol] = useState(true)
const [commandExecutionTimeout, setCommandExecutionTimeout] = useState(20)
const [terminalShellIntegrationTimeout, setTerminalShellIntegrationTimeout] = useState(30) // seconds

Expand Down Expand Up @@ -464,7 +462,6 @@ export function NewRun() {
...(runValues.settings || {}),
apiProvider: "openrouter",
openRouterModelId: selection.model,
toolProtocol: useNativeToolProtocol ? "native" : "xml",
commandExecutionTimeout,
terminalShellIntegrationTimeout: terminalShellIntegrationTimeout * 1000,
}
Expand All @@ -474,7 +471,6 @@ export function NewRun() {
...(runValues.settings || {}),
apiProvider: "roo",
apiModelId: selection.model,
toolProtocol: useNativeToolProtocol ? "native" : "xml",
commandExecutionTimeout,
terminalShellIntegrationTimeout: terminalShellIntegrationTimeout * 1000,
}
Expand All @@ -485,7 +481,6 @@ export function NewRun() {
...EVALS_SETTINGS,
...providerSettings,
...importedSettings.globalSettings,
toolProtocol: useNativeToolProtocol ? "native" : "xml",
commandExecutionTimeout,
terminalShellIntegrationTimeout: terminalShellIntegrationTimeout * 1000,
}
Expand All @@ -512,7 +507,6 @@ export function NewRun() {
configSelections,
importedSettings,
router,
useNativeToolProtocol,
commandExecutionTimeout,
terminalShellIntegrationTimeout,
],
Expand Down Expand Up @@ -688,26 +682,6 @@ export function NewRun() {
</div>
)}

<div className="mt-4 p-4 rounded-md bg-muted/30 border border-border space-y-3">
<Label className="text-sm font-medium text-muted-foreground">
Tool Protocol Options
</Label>
<div className="flex flex-col gap-2.5 pl-1">
<label
htmlFor="native-other"
className="flex items-center gap-2 cursor-pointer">
<Checkbox
id="native-other"
checked={useNativeToolProtocol}
onCheckedChange={(checked: boolean) =>
setUseNativeToolProtocol(checked)
}
/>
<span className="text-sm">Use Native Tool Calls</span>
</label>
</div>
</div>

{settings && (
<SettingsDiff defaultSettings={EVALS_SETTINGS} customSettings={settings} />
)}
Expand Down Expand Up @@ -792,26 +766,6 @@ export function NewRun() {
</div>
))}
</div>

<div className="mt-4 p-4 rounded-md bg-muted/30 border border-border space-y-3">
<Label className="text-sm font-medium text-muted-foreground">
Tool Protocol Options
</Label>
<div className="flex flex-col gap-2.5 pl-1">
<label
htmlFor="native"
className="flex items-center gap-2 cursor-pointer">
<Checkbox
id="native"
checked={useNativeToolProtocol}
onCheckedChange={(checked: boolean) =>
setUseNativeToolProtocol(checked)
}
/>
<span className="text-sm">Use Native Tool Calls</span>
</label>
</div>
</div>
</>
)}

Expand Down
129 changes: 0 additions & 129 deletions packages/core/src/custom-tools/__tests__/__snapshots__/format-xml.spec.ts.snap
View file
Open in desktop

This file was deleted.

Loading
Loading