-
Notifications
You must be signed in to change notification settings - Fork 2.8k
refactor: extract setTaskTitle handler to separate module #10838
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Review complete. No issues found. This is a clean refactoring that extracts the Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues. |
Review complete. No issues found. This is a clean refactoring that extracts the Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues. |
…ow render without font-semibold
Co-authored-by: Seth Miller <sethmillerp@gmail.com>
170975d to
7d234d2
Compare
7d234d2 to
1440281
Compare
Related GitHub Issue
Depends on: #8689 (should be merged after #8689)
Description
This PR extracts the
setTaskTitlemessage handler logic fromwebviewMessageHandler.tsinto a dedicated module (taskTitleHandler.ts), improving code organization and maintainability.Changes:
src/core/webview/taskTitleHandler.tswith the extracted handler logicwebviewMessageHandler.tsto use the extracted handlerHistoryItemimport fromwebviewMessageHandler.tsnormalizeTitle()function for cleaner title normalizationBenefits:
webviewMessageHandler.tsfilecheckpointRestoreHandler.ts,diagnosticsHandler.ts)Test Procedure
Documentation Updates
View task on Roo Code Cloud
Important
Refactor
setTaskTitlehandler into a separate module and introduce editable task titles feature across UI components and settings.setTaskTitlehandler fromwebviewMessageHandler.tstotaskTitleHandler.ts.normalizeTitle()function intaskTitleHandler.tsfor title sanitization and normalization.TaskHeader.tsxandTaskItem.tsx.UISettings.tsxto include a toggle for enabling task titles.taskTitlesEnabledto global settings schema inglobal-settings.ts.ExtensionStateinvscode-extension-host.tsto includetaskTitlesEnabled.TaskHeader.spec.tsxandTaskItem.spec.tsx.HistoryItemimport fromwebviewMessageHandler.ts.This description was created by
for 1440281. You can customize this summary. It will automatically update as commits are pushed.