fix: Shift+Enter now inserts newline when Ctrl+Enter to send is enabled #10829
+20
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to address Issue #10386. Feedback and guidance are welcome.
Problem
When "Ctrl+Enter to send" mode is enabled (
enterBehavior === "newline"), pressing Shift+Enter was sending the message instead of inserting a newline. This was contrary to user expectations and standard text editing behavior.Root Cause
In
ChatTextArea.tsx, thehandleKeyDownfunction hadevent.shiftKeyincluded in the send condition:Solution
Removed
event.shiftKeyfrom the condition so only Ctrl/Cmd+Enter triggers send:Expected Behavior After Fix
When
enterBehavior === "newline"(Ctrl+Enter to send enabled):Testing
Closes #10386
Important
Fix
ChatTextArea.tsxto allow Shift+Enter to insert newline when Ctrl+Enter to send is enabled, updating tests accordingly.handleKeyDowninChatTextArea.tsxto removeevent.shiftKeyfrom send condition, allowing Shift+Enter to insert newline whenenterBehavior === "newline".ChatTextArea.spec.tsxto verify Shift+Enter inserts newline and Ctrl/Cmd+Enter sends message.ChatTextArea.spec.tsxpass.This description was created by
for fe682d8. You can customize this summary. It will automatically update as commits are pushed.