Conversation
There was a problem hiding this comment.
Code Review
This pull request implements the Player domain, encompassing entities, repositories, services, and controllers for managing player resources, stages, sessions, weapons, and skills. It also introduces several agent skills for automation—including build, test, code-review, and database migration—and updates repository guidelines and request flow documentation. Feedback focuses on ensuring atomicity in service operations through database transactions, adhering to the project's style guide regarding explicit typing, optimizing repository lookup performance using dictionaries, and externalizing hardcoded configuration values.
Fantasy-server/Fantasy.Server/Domain/Player/Service/InitPlayerService.cs
Outdated
Show resolved
Hide resolved
Fantasy-server/Fantasy.Server/Domain/Player/Service/EndPlayerSessionService.cs
Outdated
Show resolved
Hide resolved
Fantasy-server/Fantasy.Server/Domain/Player/Service/InitPlayerService.cs
Outdated
Show resolved
Hide resolved
Fantasy-server/Fantasy.Server/Domain/Player/Repository/PlayerSkillRepository.cs
Outdated
Show resolved
Hide resolved
Fantasy-server/Fantasy.Server/Domain/Player/Repository/PlayerWeaponRepository.cs
Outdated
Show resolved
Hide resolved
Fantasy-server/Fantasy.Server/Domain/Player/Repository/PlayerRedisRepository.cs
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
작업 내용
ICurrentUserProvider.GetAccountId()를 추가했습니다.참고사항
플레이어 데이터 API 추가가 이번 변경의 핵심이며, 에이전트 스킬 문서 정비 커밋도 함께 포함되어 있습니다.
체크리스트