Skip to content

test: 골드 던전 테스트 예외 검증 방식 정리#14

Merged
Sean-mn merged 2 commits intochore/deploy-pipelinefrom
test/unusesd-catch
Apr 8, 2026
Merged

test: 골드 던전 테스트 예외 검증 방식 정리#14
Sean-mn merged 2 commits intochore/deploy-pipelinefrom
test/unusesd-catch

Conversation

@Sean-mn
Copy link
Copy Markdown
Contributor

@Sean-mn Sean-mn commented Apr 8, 2026

작업 내용

  • 골드 던전 테스트에서 빈 catch 블록을 제거했습니다
  • BadRequestException 발생을 FluentAssertions 방식으로 명확하게 검증하도록 수정했습니다

추가 참고사항

테스트 의도를 더 분명하게 드러내고, 예외를 조용히 삼키지 않도록 정리한 변경입니다.

체크리스트

[ ]안에 x를 작성하면 체크박스를 체크할 수 있습니다.

  • 현재 하려고 하는 기능이 정상적으로 작동하나요?
  • 변경한 기능이 다른 기능에 영향을 끼치지 않나요?

@Sean-mn Sean-mn added the enhancement:개선사항 New feature or request label Apr 8, 2026
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the GoldDungeonServiceTests to use FluentAssertions for verifying that a BadRequestException is thrown, replacing a manual try-catch block. The review feedback suggests simplifying the lambda expression used for the exception check by removing redundant async/await keywords to avoid unnecessary state machine overhead and improve code conciseness.

@Sean-mn Sean-mn merged commit 3c48b00 into chore/deploy-pipeline Apr 8, 2026
1 check passed
@Sean-mn Sean-mn deleted the test/unusesd-catch branch April 8, 2026 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement:개선사항 New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant