test: 골드 던전 테스트 예외 검증 방식 정리#14
Merged
Sean-mn merged 2 commits intochore/deploy-pipelinefrom Apr 8, 2026
Merged
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the GoldDungeonServiceTests to use FluentAssertions for verifying that a BadRequestException is thrown, replacing a manual try-catch block. The review feedback suggests simplifying the lambda expression used for the exception check by removing redundant async/await keywords to avoid unnecessary state machine overhead and improve code conciseness.
Fantasy-server/Fantasy.Test/Dungeon/Service/GoldDungeonServiceTests.cs
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
작업 내용
catch블록을 제거했습니다BadRequestException발생을 FluentAssertions 방식으로 명확하게 검증하도록 수정했습니다추가 참고사항
테스트 의도를 더 분명하게 드러내고, 예외를 조용히 삼키지 않도록 정리한 변경입니다.
체크리스트