Skip to content

add back deterministic streamer mode#32

Open
Kaiyotech wants to merge 1 commit intoRolv-Arild:masterfrom
Kaiyotech:add_back_deterministic_stream
Open

add back deterministic streamer mode#32
Kaiyotech wants to merge 1 commit intoRolv-Arild:masterfrom
Kaiyotech:add_back_deterministic_stream

Conversation

@Kaiyotech
Copy link
Copy Markdown
Contributor

No description provided.

@Rolv-Arild
Copy link
Copy Markdown
Owner

Is this still a missing feature?

@Kaiyotech
Copy link
Copy Markdown
Contributor Author

Sort of. Mine is a parameter I can turn on and off, the version in main is always deterministic if streaming I think.

@Rolv-Arild
Copy link
Copy Markdown
Owner

Actually the check is for streamer_mode > 1, so it is still an option, although definitely a bit obscure.
https://github.com/Rolv-Arild/rocket-learn/blob/master/rocket_learn/rollout_generator/redis/redis_rollout_worker.py#L385

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants