-
Notifications
You must be signed in to change notification settings - Fork 11
Fix: Update station edit form 3rd section header to show 'Data Source' #1047
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Fix: Update station edit form 3rd section header to show 'Data Source' #1047
Conversation
WalkthroughThis PR corrects a mislabeled field in the deployment details form by replacing a reference to "Source Images" with the correct "Data Source" label constant, and ensures consistent capitalization in the corresponding language strings file. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes
Poem
Pre-merge checks and finishing touches✅ Passed checks (5 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
✅ Deploy Preview for antenna-preview canceled.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
ui/src/utils/language.ts (1)
396-396: Consider using sentence case for consistency.The capitalization 'Data Source' (title case) differs from the sentence case pattern used by other field labels like 'Source images' (line 394), 'General configuration' (line 356), and 'Source image' (line 393).
Apply this diff for consistency:
- [STRING.FIELD_LABEL_DATA_SOURCE]: 'Data Source', + [STRING.FIELD_LABEL_DATA_SOURCE]: 'Data source',
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
ui/src/pages/deployment-details/deployment-details-form/deployment-details-form.tsx(2 hunks)ui/src/utils/language.ts(1 hunks)
🧰 Additional context used
🧬 Code graph analysis (1)
ui/src/pages/deployment-details/deployment-details-form/deployment-details-form.tsx (1)
ui/src/utils/language.ts (1)
translate(594-611)
🔇 Additional comments (2)
ui/src/pages/deployment-details/deployment-details-form/deployment-details-form.tsx (2)
3-4: LGTM!The import formatting is clean and improves readability.
148-148: Excellent fix—correctly addresses the mislabeled section header.The change from
FIELD_LABEL_SOURCE_IMAGEStoFIELD_LABEL_DATA_SOURCEproperly reflects the section's purpose, which configures data source settings (data source ID, subdirectory, and regex pattern). This resolves the issue described in #714.
|
Thank you @weknowthecalmat! I will review shortly! |
bf9d55c to
528b413
Compare
Summary
Brief description of what this PR does. (tl;dr).
Update station edit form 3rd section header to show 'Data Source'
List of Changes
Related Issues
Closes #714
Detailed Description
This PR relates to #714 and solves the issue of incorrect section header for 'Stations'
How to Test the Changes
Navigate to Projects -> Stations -> Choose a Station -> Click on Edit -> View the updated section header
Screenshots
Before:
After:
Checklist
Summary by CodeRabbit