Skip to content

[NEW] add menubar commponent #155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
irffanasiff wants to merge 8 commits into
base: main
Choose a base branch
from
Open

[NEW] add menubar commponent #155

irffanasiff wants to merge 8 commits into from
+327 −3

Conversation

@irffanasiff
Copy link
Contributor

@irffanasiff irffanasiff commented May 22, 2022

This commit will add a new menubar component with UI improvements for both mobile and desktop screens.

Mentioned in issue #60

Desktop Screen Demo -
gnome-shell-screenshot-93MQM1
gnome-shell-screenshot-93R9L1

Mobile Screen Demo -
gnome-shell-screenshot-IHHSM1

@irffanasiff irffanasiff changed the title adds the new menu bar commponent [ADD] new menu bar commponent May 22, 2022
@irffanasiff irffanasiff changed the title [ADD] new menu bar commponent [ADD] new menubar commponent May 22, 2022
@lgtm-com
Copy link

lgtm-com bot commented May 22, 2022

This pull request introduces 1 alert when merging a032783 into 4481743 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@irffanasiff irffanasiff changed the title [ADD] new menubar commponent [NEW] add menubar commponent May 22, 2022
Sing-Li
Sing-Li requested changes May 22, 2022
View reviewed changes
Copy link
Member

@Sing-Li Sing-Li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@demonicirfan Please fix the build problem - as we like to have this new design in before we start on the web3 / nft deployment scenario (site). Thanks.

@Sing-Li
Copy link
Member

Sing-Li commented May 22, 2022

@demonicirfan Please fix the build problem - as we like to have this new design in before we start on the web3 / nft deployment scenario (site). Thanks.

Don't hesitate to consult with team members or ask them to help in their specialty area(s). We're all in this together. Thanks.

@Sing-Li Sing-Li added this to the GSoC 2022 Alumni Summit milestone May 23, 2022
@lgtm-com
Copy link

lgtm-com bot commented May 27, 2022

This pull request introduces 1 alert when merging 1eaed70 into 6dd0812 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@irffanasiff irffanasiff requested a review from Sing-Li May 27, 2022 10:15
@irffanasiff
Copy link
Contributor Author

irffanasiff commented May 27, 2022

@Sing-Li i have fixed the build issue please have a look

@lgtm-com
Copy link

lgtm-com bot commented May 27, 2022

This pull request introduces 1 alert when merging b2b5a52 into 6dd0812 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Jun 9, 2022

This pull request introduces 1 alert when merging 2df61a8 into 763d0ab - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@sidmohanty11 sidmohanty11 mentioned this pull request Jul 3, 2022
Merged
3 tasks
@Dnouv Dnouv mentioned this pull request Nov 3, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Sing-Li Sing-Li Awaiting requested review from Sing-Li

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

GSoC 2022 Alumni Summit

Development

Successfully merging this pull request may close these issues.

2 participants

@irffanasiff @Sing-Li