Skip to content

Conversation

@umangutkarsh
Copy link
Contributor

@umangutkarsh umangutkarsh commented Jan 14, 2024

Addresses: #76

Removed the unused imports from the following files.

  • ExecuteViewSubmitHandler.ts
  • ExecuteActionButtonHandler.ts
  • commandUtility.ts
  • DeleteModal.ts

@Sumitwarrior7
Copy link
Contributor

You can remove unused imports from other files as well, that will be good

And just cross verify everything works fine

@umangutkarsh
Copy link
Contributor Author

You can remove unused imports from other files as well, that will be good

And just cross verify everything works fine

@Sumitwarrior7 . These are the imports which are unused. Also I am facing one issue, the changes I make in the codebase of Apps.Whiteboard are not being rendered on the server, I'm not able to see the changes. Can you help out with this?
Thanks.

@Sumitwarrior7
Copy link
Contributor

Whenever you make the changes and want to see the changes in the server, you have to rerun the build commands for building the whiteboard app as given in readme

@CulturalProfessor
Copy link
Collaborator

You can remove unused imports from other files as well, that will be good

And just cross verify everything works fine

@umangutkarsh please confirm if it's done then we can close it

@umangutkarsh
Copy link
Contributor Author

Hi @CulturalProfessor . Will confirm asap. Thanks.

@umangutkarsh
Copy link
Contributor Author

You can remove unused imports from other files as well, that will be good
And just cross verify everything works fine

@umangutkarsh please confirm if it's done then we can close it

Hi @CulturalProfessor . I have cross-verified. And Removed the imports, we can close this. Also there are some unused attributes defined in the constructor classes in some files. I have not removed those.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants