Added Italian caduti grande guerra site#318
Added Italian caduti grande guerra site#318tigert-creator wants to merge 8 commits intoRobPavey:developfrom
Conversation
There was a problem hiding this comment.
Ideally all file names would be lower case. It can be hard to change them once they have been put in git though. Though I think it is possible: https://adamj.eu/tech/2022/12/09/git-change-case-of-filenames/
| let fieldData = {}; | ||
| let selectData = {}; | ||
|
|
||
| //!!!!!!!!!! CHANGES NEEDED HERE AFTER RUNNING create_new_site SCRIPT !!!!!!!!!! |
There was a problem hiding this comment.
Does the site not support search or have you just not implemented it yet?
| @@ -0,0 +1,314 @@ | |||
| <!-- saved from url=(0093)https://www.cadutigrandeguerra.it/DettagliNominativi.aspx?id=SQ%2bRzkCbzdmuTr%2buc7TPaw%3d%3d --> | |||
There was a problem hiding this comment.
I keep all file names lower case because some file systems cannot distinguish between upper and lower case, which then causes issues with git.
|
Thanks for renaming the unit test files. I still have one outstanding question about the search. Are you planning to implement the search but have not gotten to it yet? In itcadgg_popup_search.mjs you have: I think this is just the line generated by the my script - it doesn't know what the search URL should be. https://www.itcadgg.org/search is not a valid URL. It looks like it should be: If you want, I can merge this PR and you can keep working on the search. |
|
Hi, I don't know who you are from your GitHub ID. Can you share your wiki ID? Are you on Discord? |
2 participants
Able to create a citation for https://www.cadutigrandeguerra.it/ (Italian fallen in the Great War)