Preserve the filename in “Open in browser as” mode #78
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of general types like `Array` and `object`, use specific types from the @types/chrome NPM package. This modifies only the JSDoc comments, without any functional changes.
The filename may be used even if the user chooses “Open in browser as”. I found two cases when this happens: - The user chooses this option, but the browser can’t actually handle the given MIME type, and downloads the file anyway. (This can be used for example to force downloading XPIs or JARs as simple ZIP files.) - The file is a PDF file. Firefox uses the filename when the file is subsequently saved from the PDF.js toolbar, as well as in the tab title.
Author
|
Hi @Rob--W, could you please review this? Not super urgent, but it annoys me constantly because I primarily use this extension to force opening PDFs in Firefox, many of which have no human-readable tab titles due to this bug. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The filename may be used even if the user chooses “Open in browser as”. I found two cases when this happens: