simplify checksum function #505
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| hash ^= uint64(val & 0xFF) | ||
| hash *= prime | ||
| // Hash high byte | ||
| hash ^= uint64(val >> 8) |
Collaborator
There was a problem hiding this comment.
Should this be val >> 8 & 0xFF? I guess it doesn't matter as it's a uint16. It was just visually noticeable compare to the block above.
Member
Author
There was a problem hiding this comment.
I think it is ok because the semantic is clear.
Collaborator
|
Looks good to me:
|
Member
Author
|
@happygiraffe Thanks. I will let it stew in case someone has other comments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simplifies the CheckSum function. I am not expecting nor seeing a performance difference. I am also adding a check to make sure we do not check the CheckSum results.