This repository was archived by the owner on Jan 2, 2022. It is now read-only.
Fixed bug - false detection of circular reference#21
Open
parvanov wants to merge 2 commits intoRitwikSaikia:masterfrom
Open
Fixed bug - false detection of circular reference#21parvanov wants to merge 2 commits intoRitwikSaikia:masterfrom
parvanov wants to merge 2 commits intoRitwikSaikia:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a bug in detection of circular reference.
It was adding the class of each field as it was entering it, but it wasn't removing it once it exists the field.
As a result, any class with 2 or more fields of the same class was wrongly giving an error.
Added
visited.remove(clazz);
to fix it.
Note the pull request has 2 commits even though one is already merged.
The fix consists only of commit parvanov@e89c8b7