Skip to content

Conversation

@metaprime
Copy link
Contributor

Replaces #176 by @cyian-1756

Category

This change is exactly one of the following (please change [ ] to [x]) to indicate which:

Description

I removed all the code for logging in (Which ripme was not able to go anymore due to a change in the login system) so the ripper can now rip all public albums.

Testing

Required verification:

  • I've verified that there are no regressions in mvn test (there are no new failures or errors).
  • I've verified that this change works as intended.
    • Downloads all relevant content.
    • Downloads content from multiple pages (as necessary or appropriate).
    • Saves content at reasonable file names (e.g. page titles or content IDs) to help easily browse downloaded content.
  • I've verified that this change did not break existing functionality (especially in the Ripper I modified).

Optional but recommended:

  • I've added a unit test to cover my change.

@coveralls
Copy link

coveralls commented Nov 21, 2017

Coverage Status

Coverage increased (+0.4%) to 28.403% when pulling eb7fcac on metaprime:fix-furaffinity into f630123 on RipMeApp:master.

@metaprime metaprime merged commit 89fbe26 into RipMeApp:master Nov 21, 2017
@metaprime metaprime deleted the fix-furaffinity branch November 21, 2017 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Disabled test: BasicRippersTest#testFuraffinityAlbum -- fix and re-enable or remove

2 participants