Open
Conversation
Contributor
There was a problem hiding this comment.
We shouldn't change this file in pull requests. It will be changed when a new version is released.
Contributor
|
This functionality is very useful, but I am a bit hesitant to merge this without any testing. @i11, do you think you could create a VM with Nexus and add some Cucumber tests for this functionality? Traditionally, I've tested this by configuring a combination of VirtualBox, Vagrant, Berkshelf, and the https://github.com/RiotGames/nexus-cookbook. edit: Also this needs to be rebased against master. |
Author
|
Understandable. I have nexus-cookbook changes which can be pull requested as well. Do you want me to upload vbox somewhere particular? I will rebase, squash and remove version change soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User to role mapping actions used to map external user credentials (e.g. LDAP) to specific nexus roles